This repository has been archived by the owner on Aug 24, 2019. It is now read-only.
Add nullability annotations #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to resolve this conflict and merge. Really want to squash the implicit optionals |
|
rebased |
carlosalban
reviewed
May 2, 2018
| @@ -105,15 +107,15 @@ typedef NS_ENUM(NSUInteger, SSPullToRefreshViewStyle) { | |||
|
|
|||
| @see initWithScrollView:delegate: | |||
| */ | |||
| @property (nonatomic, assign, readonly) UIScrollView *scrollView; | |||
| @property (nonatomic, weak, readonly, nullable) UIScrollView *scrollView; | |||
There was a problem hiding this comment.
FYI, the change from assign to weak caused a crash for me:
Fatal Exception: NSInternalInconsistencyException
An instance 0x1062ae600 of class UICollectionView was deallocated while key value observers were still registered with it. Current observation info: <NSKeyValueObservationInfo 0x17082c9a0> ( <NSKeyValueObservance 0x171243ea0: Observer: 0x105d80720, Key path: contentOffset, Options: <New: YES, Old: NO, Prior: NO> Context: 0x105d80720, Property: 0x174c42d30> )
It occurs on iOS 9 & 10 (not 11), when popping from one VC to another, both with a collection view with a pull to refresh.
There was a problem hiding this comment.
revert back to unsafe_unretained (same as assign). this is because of kvo. ref: https://stackoverflow.com/questions/10793206/how-do-you-remove-kvo-from-a-weak-property posted by sam himself
lemme know if this works
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.