[Core,Helper] Prevent to create objects from unloaded plugins #4722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
the
pr: status to review
bakpaul
reviewed
May 7, 2024
| @@ -229,6 +231,8 @@ class SOFA_HELPER_API PluginManager | |||
|
|
|||
| PluginMap m_pluginMap; | |||
| std::map<std::string, std::function<void(const std::string&, const Plugin&)>> m_onPluginLoadedCallbacks; | |||
|
|
|||
| sofa::type::vector<std::string> m_unloadedPlugins; | |||
There was a problem hiding this comment.
Why a vector and not a unordered_set since this name should be unique ? All the modifications could be done through the key directly
bakpaul
added
pr: status postponed
|
To be discussed at the STC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a plugin is loaded, the ObjectFactory is populated of Components from this plugin. However, when this plugin "unloaded", it was still possible to create a component from the plugin. This PR detects that the ObjectFactory tries to instantiate an object that is from an unloaded plugin.
It is particularly useful when the initialization of the plugin fails (SofaCUDA for example). When the initialization fails, the plugin is unloaded.
A unit test is provided
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if