Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Use MeshMatrixMass in hyperelastic examples #4687

Merged

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Apr 26, 2024

Since users often copy paste examples, let's show good scene habits: when modeling volumetric, the MeshMatrixMass should be used instead.

I guess this will trigger the regression tests (but I need to recompile regression first, so I give the CI a chance :) )

[ci-depends-on https://github.com/sofa-framework/Regression/pull/64]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Apr 26, 2024
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@sofabot
Copy link
Collaborator

sofabot commented Apr 28, 2024

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the regression reference and go

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels May 7, 2024
@alxbilger alxbilger added this to the v24.06 milestone May 22, 2024
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels May 22, 2024
@alxbilger
Copy link
Contributor

[ci-build][with-all-tests]

@sofabot
Copy link
Collaborator

sofabot commented May 22, 2024

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

@alxbilger
Copy link
Contributor

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented May 22, 2024

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

@bakpaul bakpaul added the pr: backport todo This PR will be backported into the release preceeding its milestone. label May 27, 2024
@sofabot
Copy link
Collaborator

sofabot commented May 27, 2024

[ci-depends-on] detected during build #6.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@hugtalbot
Copy link
Contributor Author

LGTM

@sofabot
Copy link
Collaborator

sofabot commented May 28, 2024

[ci-depends-on] detected during build #7.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@bakpaul
Copy link
Contributor

bakpaul commented May 28, 2024

[ci-build][with-all-tests]

@sofabot
Copy link
Collaborator

sofabot commented May 28, 2024

[ci-depends-on] detected during build #8.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@sofabot
Copy link
Collaborator

sofabot commented May 30, 2024

[ci-depends-on] detected during build #9.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@bakpaul bakpaul merged commit d5e0fdb into sofa-framework:master May 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: backport todo This PR will be backported into the release preceeding its milestone. pr: status to review To notify reviewers to review this pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants