Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visual] Rename Data #4684

Merged
merged 13 commits into from
May 24, 2024
Merged

[Visual] Rename Data #4684

merged 13 commits into from
May 24, 2024

Conversation

lamriaimen
Copy link
Contributor

According to the guidelines

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request refactoring Refactor code labels Apr 26, 2024
@alxbilger
Copy link
Contributor

[ci-build][with-all-tests]

@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels May 7, 2024
@fredroy
Copy link
Contributor

fredroy commented May 16, 2024

[ci-build][with-all-tests]

@hugtalbot hugtalbot added this to the v24.06 milestone May 22, 2024
lamriaimen and others added 9 commits May 22, 2024 12:02
@lamriaimen @alxbilger
[Visual] Rename Data
d4d9afd
@lamriaimen @alxbilger
Update Sofa/Component/Visual/src/sofa/component/visual/VisualModelImp…
42459e6 
…l.cpp

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@lamriaimen @alxbilger
Update Sofa/Component/Visual/src/sofa/component/visual/VisualModelImp…
ff9612d 
…l.cpp

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@lamriaimen @alxbilger
Update Sofa/Component/Visual/src/sofa/component/visual/VisualModelImp…
20fc7e3 
…l.cpp

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@lamriaimen @alxbilger
Update Sofa/Component/Visual/src/sofa/component/visual/VisualModelImp…
fc6f24d 
…l.cpp

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@lamriaimen @alxbilger
Update Sofa/Component/Visual/src/sofa/component/visual/VisualModelImp…
64e808a 
…l.cpp

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@lamriaimen @alxbilger
Update Sofa/Component/Visual/src/sofa/component/visual/VisualModelImp…
31c0a6f 
…l.cpp

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@lamriaimen @alxbilger
[Visual] Fixing issue that occurs when not initializing deprecated vars
d6b15d8
@lamriaimen @bakpaul @alxbilger
Update Sofa/Component/Visual/src/sofa/component/visual/VisualModelImp…
6fe379c 
…l.cpp

Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels May 22, 2024
lamriaimen and others added 3 commits May 24, 2024 10:28
@lamriaimen
Merge branch 'sofa-framework:master' into sofa.visual
715ec2a
@lamriaimen @fredroy
Update Sofa/Component/Collision/Geometry/src/sofa/component/collision…
656b406 
…/geometry/TriangleModel.h

Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
@lamriaimen @fredroy
Update Sofa/Component/Visual/src/sofa/component/visual/BaseCamera.h
d795509 
Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
@lamriaimen lamriaimen requested a review from alxbilger May 24, 2024 08:55
@lamriaimen lamriaimen requested a review from fredroy May 24, 2024 10:56
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 24, 2024
@fredroy fredroy merged commit cff0dd4 into sofa-framework:master May 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakpaul bakpaul bakpaul requested changes

@alxbilger alxbilger alxbilger approved these changes

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: status ready Approved a pull-request, ready to be squashed refactoring Refactor code
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lamriaimen @alxbilger @fredroy @bakpaul @hugtalbot