[Spring] Merging StiffSpringForceField and its parent #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of the force computation because it is more complete
bakpaul
added
pr: breaking
|
Let's see this as a starting point of refactoring. This PR does the merge, the code is neither better nor worst than before, it just removes unnecessary duplication. Still need to replace every iteration of StiffSpringForceField by SpringForceField and fix Cuda extension |
…n and make it the common one
bakpaul
added
pr: status wip
bakpaul
added
pr: status to review
|
[ci-build][with-all-tests] |
|
PR is ready for me now. |
|
[ci-build][with-all-tests] |
|
[ci-build][with-all-tests] |
alxbilger
reviewed
Apr 29, 2024
...onent/SolidMechanics/Spring/src/sofa/component/solidmechanics/spring/StiffSpringForceField.h
Outdated
Show resolved
Hide resolved
Sofa/GUI/Component/src/sofa/gui/component/performer/AttachBodyPerformer.inl
Outdated
Show resolved
Hide resolved
...tions/plugins/SofaCUDA/src/SofaCUDA/component/solidmechanics/spring/CudaSpringForceField.cpp
Show resolved
Hide resolved
…echanics/spring/StiffSpringForceField.h Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
Remove commented code
…ngff_and_springff
bakpaul
added
pr: status wip
bakpaul
force-pushed
the
fusion_of_stiffspringff_and_springff
branch
from
de5c7a2
to
beff7ab
Compare
bakpaul
added
pr: status to review
|
[ci-build][with-all-tests] |
bakpaul
added
pr: status wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StiffSpringForceField is basically an extension of SpringForcefield adding implicit solving.
The only added value comes from the ability to define the springs using added data indices1, indices2 and lengths. This mechanism need to also be merged with the current one available in SpringForceField.
Related to #248
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if