[ODESolver] Explicit link to linear solver #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
pr: status to review
|
[ci-build][with-all-tests] |
1 similar comment
|
[ci-build][with-all-tests] |
epernod
reviewed
Apr 8, 2024
|
Why add a diamond inheritance instead of modifying directly the common parent class ODESolver ? |
|
Because explicit solvers do not necessarily require a linear solver |
hugtalbot
reviewed
Apr 9, 2024
Sofa/framework/Simulation/Core/src/sofa/simulation/MechanicalOperations.cpp
Show resolved
Hide resolved
Sofa/Component/ODESolver/Backward/src/sofa/component/odesolver/backward/EulerImplicitSolver.h
Show resolved
Hide resolved
hugtalbot
added
pr: status wip
alxbilger
added
pr: status to review
alxbilger
force-pushed
the
explicitlinearsolver
branch
from
6e0d62d
to
f8114b9
Compare
hugtalbot
reviewed
May 13, 2024
Sofa/Component/ODESolver/Forward/src/sofa/component/odesolver/forward/EulerSolver.cpp
Show resolved
Hide resolved
Comment on lines
32
to
41
| if (!l_linearSolver.get()) | ||
| { | ||
| l_linearSolver.set(getContext()->get<LinearSolver>()); | ||
|
|
||
| if (!l_linearSolver) | ||
| { | ||
| msg_error() << "A linear solver is required by this component but has not been found."; | ||
| this->d_componentState.setValue(sofa::core::objectmodel::ComponentState::Invalid); | ||
| } | ||
| } |
There was a problem hiding this comment.
We could also make this as a callback
Sofa/framework/Simulation/Core/src/sofa/simulation/MechanicalOperations.cpp
Show resolved
Hide resolved
alxbilger
force-pushed
the
explicitlinearsolver
branch
from
f8114b9
to
f633fd1
Compare
fredroy
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It basically removes the use of
MultiMatrixwhich hides the use of aLinearSolver. Implicitly, the first linear solver found was used. Now, theLinearSolvercan be defined directly in the ODE solver as a Link.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if