-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI.Qt] Refactor a bit the way runSofa is implementing the scenegraph colors #4536
Open
damienmarchal
wants to merge
6
commits into
sofa-framework:master
Choose a base branch
from
CRIStAL-PADR:xp-refactor-color
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[GUI.Qt] Refactor a bit the way runSofa is implementing the scenegraph colors #4536
damienmarchal
wants to merge
6
commits into
sofa-framework:master
from
CRIStAL-PADR:xp-refactor-color
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmarchal
added
pr: status to review
To notify reviewers to review this pull-request
pr: experimental
Demonstrate an experimental feature
pr: dev meeting topic
PR to be discussed in sofa-dev meeting
pr: status wip
Development in the pull-request is still in progress
and removed
pr: experimental
Demonstrate an experimental feature
labels
Feb 27, 2024
hugtalbot
removed
the
pr: status wip
Development in the pull-request is still in progress
label
Feb 28, 2024
damienmarchal
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Feb 28, 2024
hugtalbot
added
refactoring
Refactor code
and removed
pr: dev meeting topic
PR to be discussed in sofa-dev meeting
labels
Feb 28, 2024
damienmarchal
force-pushed
the
xp-refactor-color
branch
from
February 28, 2024 13:31
a0cc347
to
3558bf4
Compare
damienmarchal
added
pr: status to review
To notify reviewers to review this pull-request
NG4: remove-plugins
See https://github.com/sofa-framework/sofa/issues/1527
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status wip
Development in the pull-request is still in progress
NG4: remove-plugins
See https://github.com/sofa-framework/sofa/issues/1527
pr: status to review
To notify reviewers to review this pull-request
labels
Mar 26, 2024
bakpaul
changed the title
Refactor a bit the way runSofa is implementing the scenegraph colors
[GUI.Qt] Refactor a bit the way runSofa is implementing the scenegraph colors
Mar 27, 2024
PR just got updated.
→ wip : PR should keep only the 2-line change |
@hugtalbot I don't understand what you are refering by 2-line change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has flawns among which:
Here is a small attempt to change some of these aspects without the ambition to fix everything.
Additionally, I would like to be able to add more colors/rendering scheme for objects that are not part of the base framework and wonder if we need to implement an extension mechanism so that object defines in plugins (eg: sofapython3::BasePrefab) can propose their own icon in the scene graph.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if