Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI.Qt] Refactor a bit the way runSofa is implementing the scenegraph colors #4536

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Feb 27, 2024

The current implementation has flawns among which:

  • lack of factorization between node & object rendering in the scenegraph view;
  • the use of hardcoded color scheme in simulation:Colors

Here is a small attempt to change some of these aspects without the ambition to fix everything.
Additionally, I would like to be able to add more colors/rendering scheme for objects that are not part of the base framework and wonder if we need to implement an extension mechanism so that object defines in plugins (eg: sofapython3::BasePrefab) can propose their own icon in the scene graph.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request pr: experimental Demonstrate an experimental feature pr: dev meeting topic PR to be discussed in sofa-dev meeting pr: status wip Development in the pull-request is still in progress and removed pr: experimental Demonstrate an experimental feature labels Feb 27, 2024
@hugtalbot hugtalbot removed the pr: status wip Development in the pull-request is still in progress label Feb 28, 2024
@damienmarchal damienmarchal added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Feb 28, 2024
@hugtalbot hugtalbot added refactoring Refactor code and removed pr: dev meeting topic PR to be discussed in sofa-dev meeting labels Feb 28, 2024
@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request NG4: remove-plugins See https://github.com/sofa-framework/sofa/issues/1527 pr: status wip Development in the pull-request is still in progress and removed pr: status wip Development in the pull-request is still in progress NG4: remove-plugins See https://github.com/sofa-framework/sofa/issues/1527 pr: status to review To notify reviewers to review this pull-request labels Mar 26, 2024
@bakpaul bakpaul changed the title Refactor a bit the way runSofa is implementing the scenegraph colors [GUI.Qt] Refactor a bit the way runSofa is implementing the scenegraph colors Mar 27, 2024
@hugtalbot
Copy link
Contributor

PR just got updated.
Several points are below this PR:

  • define a new design for managing colors by component
  • should the color API allow for new colors
  • Should Prefab be refactored in Sofa.Core ?

→ wip : PR should keep only the 2-line change

@damienmarchal
Copy link
Contributor Author

@hugtalbot I don't understand what you are refering by 2-line change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: status wip Development in the pull-request is still in progress refactoring Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants