Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] POC: enable assertions even in release mode #4496

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Feb 13, 2024

⚠️ DO NOT MERGE ! ⚠️

The CI only compiles in debug for one configuration and only when a commit is done on the master.
AND a lot of failures just happen because of timeouts. So the readings are uncomfortable, to say the least

So This PR simply enable assertions in release mode (overriding the flags) and should show where the assertions happen,


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. pr: dev meeting topic PR to be discussed in sofa-dev meeting labels Feb 13, 2024
@fredroy fredroy marked this pull request as draft February 13, 2024 07:58
@fredroy
Copy link
Contributor Author

fredroy commented Feb 13, 2024

[ci-build][with-all-tests][force-full-build]

1 similar comment
@fredroy
Copy link
Contributor Author

fredroy commented Feb 13, 2024

[ci-build][with-all-tests][force-full-build]

@hugtalbot hugtalbot added the STC#17 Tasks for STC#17 coding sprint label Feb 14, 2024
@fredroy fredroy force-pushed the poc_release_with_assert branch 2 times, most recently from c444e8f to 93b73f3 Compare February 22, 2024 00:56
@fredroy
Copy link
Contributor Author

fredroy commented Feb 22, 2024

[ci-build][with-all-tests]

@fredroy fredroy removed the pr: dev meeting topic PR to be discussed in sofa-dev meeting label Feb 23, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Feb 23, 2024

[ci-build][with-all-tests]

@fredroy fredroy force-pushed the poc_release_with_assert branch 2 times, most recently from eb6ffbc to 81cee92 Compare March 26, 2024 01:05
@fredroy
Copy link
Contributor Author

fredroy commented Mar 26, 2024

[ci-build][with-all-tests][force-full-build]

@fredroy
Copy link
Contributor Author

fredroy commented Mar 27, 2024

[ci-build][with-all-tests][force-full-build]

@fredroy
Copy link
Contributor Author

fredroy commented Apr 1, 2024

[ci-build][with-all-tests][force-full-build]

1 similar comment
@fredroy
Copy link
Contributor Author

fredroy commented Apr 4, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Apr 4, 2024

[ci-depends-on] detected during build #21.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Apr 24, 2024

[ci-depends-on] detected during build #22.

To unlock the merge button, you must

@fredroy
Copy link
Contributor Author

fredroy commented Apr 24, 2024

[ci-build][with-all-tests][force-full-build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. pr: status wip Development in the pull-request is still in progress STC#17 Tasks for STC#17 coding sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants