-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Deprecates the hard coded interactions in components #4163
base: master
Are you sure you want to change the base?
[all] Deprecates the hard coded interactions in components #4163
Conversation
Sofa/GL/Component/Shader/src/sofa/gl/component/shader/LightManager.cpp
Outdated
Show resolved
Hide resolved
...gian/Model/src/sofa/component/constraint/lagrangian/model/BilateralInteractionConstraint.inl
Outdated
Show resolved
Hide resolved
This PR is removing some usefull mechanism (VTK and LightManager). In order to pass this PR, those two component would require to provide those controller and not just say "you should code them". One solution would be to remove them from the PR before merging it. |
Hello thank you for the feedback, I'm strongly reluctant to hard code in c++ trivial keyboard controller because there is a lot of boilerplate code and because this also encourage software obesity by having all the application specific's user interfaces in Sofa Core, think about just changing the keypress "a" to "b" without recompiling sofa. But I'm ok to implement that in a python controllers, does it would be ok ? |
…rangianConstraint and replace it with a controller
…th a python controller.
ee752d0
to
0a103be
Compare
[ci-build] |
[ci-build][with-all-tests] |
I think that regarding the last SOFA-Dev meeting, the deprecation date is still missing. When it is added we will be able to merge it ! |
Hard coding interaction in core component is not a good software design as it couple the behavior of a component and how it is used in the context of a specific interactive scene.
This PR remove this behavior and warns users. To avoid re-implementing things no one use, it is requested in the deprecation message that user need to report if they miss the feature so so we can restore it but with the proper software design.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if