fix: address modifier key issue on key up

socsieng · Jan 2, 2021 · 0bfa58a · 0bfa58a
1 parent 26ad67e
commit 0bfa58a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/Sources/SendKeysLib/KeyPresser.swift b/Sources/SendKeysLib/KeyPresser.swift
@@ -24,8 +24,8 @@ class KeyPresser {
     }
 
     func keyUp(event: CGEvent) -> CGEvent? {
-        let keyUpEvent = CGEvent(keyboardEventSource: CGEventSource(event: event), virtualKey: 0, keyDown: false)
-        keyUpEvent?.flags = event.flags
+        let keyCode = UInt16(event.getIntegerValueField(.keyboardEventKeycode))
+        let keyUpEvent = CGEvent(keyboardEventSource: CGEventSource(event: event), virtualKey: keyCode, keyDown: false)
         keyUpEvent?.post(tap: CGEventTapLocation.cghidEventTap)
 
         return keyUpEvent
@@ -45,7 +45,7 @@ class KeyPresser {
             }
         }
 
-        if !flags.isEmpty {
+        if !modifiers.isEmpty {
             keyEvent?.flags = flags
         }
 

diff --git a/Tests/SendKeysTests/CommandIteratorTests.swift b/Tests/SendKeysTests/CommandIteratorTests.swift
@@ -23,6 +23,15 @@ final class CommandIteratorTests: XCTestCase {
             ])
     }
 
+    func testParsesKeyPressDelete() throws {
+        let commands = getCommands(CommandsIterator("<c:delete>"))
+        XCTAssertEqual(
+            commands,
+            [
+                Command(CommandType.keyPress, ["delete"])
+            ])
+    }
+
     func testParsesKeyPressesWithModifierKey() throws {
         let commands = getCommands(CommandsIterator("<c:a:command>"))
         XCTAssertEqual(