Ubuntu Bionic Images #111
Merged
Ubuntu Bionic Images #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable at first glance. Does it make sense to try to DRY things up a bit by referencing things like |
|
I considered this when I was looking at the different repo's prior to starting. It would probably be best to have a single location where common files reside.
thoughts? |
iamjohnnym
commented
Sep 26, 2018
| puts "DEBUG: AWS_REGION unset. Defaulting to us-west-2" | ||
| end | ||
|
|
||
| if File.file?('/etc/aws/credentials') |
There was a problem hiding this comment.
This block doe not exist in runit-bionic/clortho-get
|
Yeah, it is annoying you can't just reference files in other directories.
I think you could make it work but not in a docker hub build. A separate
image or repo sounds like overkill a bit... symlinks could work assuming
docker isn't silly. Or we could just not worry for now.
…On Wed, Sep 26, 2018 at 4:52 PM, iamjohnnym ***@***.***> wrote:
I considered this when I was looking at the different repo's prior to
starting. It would probably be best to have a single location where common
files reside.
1. A separate docker image with essential-files, that can be included
with something like,
FROM socrata/build-essentials
2. A single repo's where this resides and the ability to do a git clone
3. they reside in shipyard/scripts and each base docker dir has a
symlink so that they are readily accessible.
thoughts?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#111 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAh-r8U8wHGS4Kr1ylQw8wYaOdPxURihks5ufBM9gaJpZM4W7QMd>
.
|
|
Bleh. No dice for now. Leveraging files from a dir above the Dockerfile has been an issue since 2013. Sad days. moby/moby#2745 which became moby/moby#37129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker images for Ubuntu 18.04 Bionic Support. The images reflect closely to the existing images in play. I was successful in building each of these locally.
socrata/base => socrata/base-bionic
socrata/runit => socrata/runit-bionic
socrata/python => socrata/python-bionic/2.7
socrata/python3 => socrata/python-bionic/3.6
socrata/runit-python => socrata/runit-bionic-python/2.7
=> socrata/runit-bionic-python/3.6