Partial fix #237 in client and #474 in server for duplicated reconnection in JSONP #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! Thanks! I'm running version 0.8.7, and to force everything to go through JSONP, I just changed the if block slightly that you mentioned from !io.util.ua.hasCORS to (true || (this.isXDomain() && !io.util.ua.hasCORS)) Since I'm running on the same domain, it would be nice to have the AJAX side of the if block fixed, but isn't the most horrible thing to do it this way. At least it works!!! |
|
Hello, |
|
thank you so much for that |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in client: #237
Bug in server: socketio/socket.io#474
Step to reproduce: socketio/socket.io#474 (comment)
This fix for handshake on client. Currently it fixes only JSONP kind of handshake. I'm using v0.8.4 and in this version for my case all handshakes goes through JSONP (comet.site.com <=> site.com).
But newer version of sio-client added for line: https://github.com/LearnBoost/socket.io-client/blob/master/lib/socket.js#L137
part: && !io.util.ua.hasCORS
Now, most of handshakes work through AJAX and maybe only Opera does handshake through JSONP.
And ajax-handshake isn't fixed :(.
There are two way to fix AJAX-part:
I dont know, what you think about it. Please give me feedback. If you think item 2 is preferred, I can try to implement clean solution for it.