Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
Uses
component-bind
.New behaviour
Uses javascript's native function binding, which is supported everywhere (IE9 and up). I have no qualms if this PR is rejected for the sake of the stability of the code base / "if-it's-not-broken-don't-fix-it". My thinking here is that if socket.io no longer needs a simple dependency, it's best to get rid of it.
Other information (e.g. related issues)
This is an answer to one of my questions in #1417.