Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed detaching and destroying presenter in ViewGroup after view added to container again. #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaulazat
Copy link

Steps to reproduce bug:

  1. Create view which is inherited from for example MvpFrameLayout
  2. Add view to any ViewGroup
  3. Remove from the ViewGroup (detachView() and destroy() methods from MvpPresenter will be called)
  4. Add view again to ViewGroup
  5. Remove view from ViewGroup
  6. detachView() and destroy() methods from MvpPresenter not will be called

@gaulazat
Copy link
Author

@sockeqwe fix ci, please

@sockeqwe
Copy link
Owner

sockeqwe commented Mar 22, 2019 via email

@sockeqwe
Copy link
Owner

I haven't had time yet to look into this. I dedicated some time on Wednesday evening.

@sockeqwe
Copy link
Owner

CI is working again. Please pull the master branch or copy & paste manually the .travis.ci file

@gaulazat
Copy link
Author

@sockeqwe Thanks! I pulled the master branch.

@Jacks0N23
Copy link

so?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants