This repository has been archived by the owner on Dec 5, 2021. It is now read-only.
Port to .NETStandard 2.0 #893
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
reviewed
Jan 9, 2020
| @@ -426,7 +432,7 @@ public static string WriteReadCode(Param p) | |||
| public static FileStream MakeFile(string path) | |||
| { | |||
| if (!Directory.Exists(Path.GetDirectoryName(path))) | |||
| Directory.CreateDirectory(Path.GetDirectoryName(path)); | |||
| Directory.CreateDirectory(Path.GetDirectoryName($"{currentDirectory}../../../../{path}")); | |||
There was a problem hiding this comment.
what is this? this doesn't seem to be related to .NETStandard change, or it's a changed that is not explained in the commit message
There was a problem hiding this comment.
I've got error with relative path, so it is cd to the project root from bin/debug directory
There was a problem hiding this comment.
what error? this info needs to be in the commit message
knocte
reviewed
Jan 9, 2020
| <FileAlignment>512</FileAlignment> | ||
| <TargetFrameworks>netcoreapp2.1</TargetFrameworks> |
There was a problem hiding this comment.
there's no reason to change this project's targetFramework, projects with .NETFramework 4.x can still link to .NETStandard libraries
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That port contains only nestandard2.0 due crosscompat. NETStandard 2.0 projects can be used under .net.
Dropped .NET only dependencies. Now project uses netstandard deps only.
Removed some old files in Requests, for better compile.
Remove nuspec usage. Now all in .csproj.
If that project need such upgrade merge & change it for project needs.