Skip to content
This repository has been archived by the owner on Dec 5, 2021. It is now read-only.

Some generic exceptions refactored into custom and specific exceptions #410

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mykolasglinskis
Copy link
Contributor

No description provided.

@knocte
Copy link
Collaborator

knocte commented Feb 25, 2017

Thanks for your contribution! You don't need the $ character of strings because you're not using string interpolation in them. If you remove that I'll merge this patch.

@knocte
Copy link
Collaborator

knocte commented Feb 25, 2017

(PS: You don't need to close this PR and open a new one to be able to make changes.)

@mykolasglinskis
Copy link
Contributor Author

removed interpolation

@knocte
Copy link
Collaborator

knocte commented Mar 29, 2017

Your last commit is introducing unnecessary diff noise, did you change the line endings or something?

@knocte
Copy link
Collaborator

knocte commented Apr 24, 2017

hello?

@knocte
Copy link
Collaborator

knocte commented Sep 18, 2017

@mykolasglinskis ping?

@dev-masih
Copy link
Contributor

dev-masih commented Mar 21, 2018

@knocte so the original poster wont answer anymore so i propose to close this PR and i Open another with the same changes so PR can merge into project. what do you think?

@knocte
Copy link
Collaborator

knocte commented Mar 21, 2018

@masihakbari yeah sure, we can close this one when you have opened a new one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants