interfaces: add desktop-file-prefix plug attr to desktop interface #13980
+30
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plug attribute is needed to allow snaps to have custom desktop file names. Previously, snapd installed desktop files as “$snap_$app.desktop”. This causes problems in a number of cases where desktop files are expected to follow a particular format, or have a specific name. The new plug attribute allows snaps to have custom desktop file names (prefixed with the "desktop-file-prefix" attribute value). Naming cannot be left uncontrolled, so the $MISSING constraint is added to only allow overriding "desktop-file-prefix" through the store. The process of requesting the snap declaration on the store will help ensure that the prefixes are sensible. More details can be found in the spec: SD170 Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
ZeyadYasser
added
the
Needs Samuele review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plug attribute is needed to allow snaps to have custom desktop file names.
Previously, snapd installed desktop files as
$snap_$app.desktop. This causes problems in a number of cases where desktop files are expected to follow a particular format, or have a specific name. This PR is the first step in allowing custom desktop file names.The new plug attribute allows snaps to have custom desktop file names (prefixed with the
desktop-file-prefixattribute value).Naming cannot be left uncontrolled, so the
$MISSINGconstraint is added to only allow overridingdesktop-file-prefixthrough the store. The process of requesting the snap declaration on the store will help ensure that the prefixes are sensible.More details can be found in the spec: SD170
Note:
deny-auto-connectionanddeny-connectionhad to be moved to the plug base declaration because it takes precedence as mentioned in interfaces/builtin/README.md