o/ifacestate: properly undo setup-profiles on component installation #13977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewphelpsj
force-pushed
the
fix-component-setup-profiles-undo
branch
from
2a90788
to
989ca8a
Compare
pedronis
requested changes
May 23, 2024
pedronis
approved these changes
May 23, 2024
| return err | ||
| } | ||
|
|
||
| appSet, err := appSetForTask(task, snapInfo) |
There was a problem hiding this comment.
maybe worth adding a comment here, about what is included in the appset
| return err | ||
| } | ||
|
|
||
| appSet, err := appSetForSnapRevision(st, snapInfo) |
andrewphelpsj
force-pushed
the
fix-component-setup-profiles-undo
branch
from
6c2cda2
to
89a5fad
Compare
This allows us to pass in a different app sets in doSetupProfiles and in undoSetupProfiles. The latter will not have components that were just set up in it.
andrewphelpsj
force-pushed
the
fix-component-setup-profiles-undo
branch
from
89a5fad
to
3766d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects and tests the behavior of undoing a
setup-profilestask that contains components. We changesetupProfilesForSnapto besetupProfilesForAppSet, so we can pass in aSnapAppSetthat doesn't contain the components being set up for the current task when undoing the task.