-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
many: modify snap run to understand component hooks #13976
Open
andrewphelpsj
wants to merge
16
commits into
snapcore:master
Choose a base branch
from
andrewphelpsj:component-snap-run
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Documentation -auto-
Label automatically added which indicates the change needs documentation
label
May 17, 2024
andrewphelpsj
force-pushed
the
component-snap-run
branch
3 times, most recently
from
May 23, 2024 16:24
b06f281
to
0523065
Compare
… interfaces can build a complete label expression, including component hooks
…urrent revision of a component for a snap revision
…resent snap hooks, component hooks, and apps This commit doesn't need to be here, and things will work without it. But things were getting a bit complicated in runSnapConfine with arguments that represented different things based on what we were running.
andrewphelpsj
force-pushed
the
component-snap-run
branch
from
June 6, 2024 13:18
0523065
to
85f919d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Documentation -auto-
Label automatically added which indicates the change needs documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the "snap run" command to run component hooks. It modifies the meaning of the "--hook" parameter a bit to allow snapd to run component hooks like so: