tests: kill process in interface-process-control as early as possible #13973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaning (killing) the spawned process was deferred to restore but spread waits for execute script to finish completely which causes the test to hang for the whole time of the process (sleep 5m). If the test is successful we could speed up the process by popping the clean command. Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
ZeyadYasser
added
Simple 😃
andrewphelpsj
approved these changes
May 17, 2024
olivercalder
approved these changes
May 17, 2024
@olivercalder the defer is necessary for the case when the test fails before the last kill command (#12611), and double kill could accidentally kill another process that reused the killed process pid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning (killing) the spawned process was deferred to restore but spread waits for execute script to finish completely which causes the test to hang for the whole time of the process (sleep 5m).
If the test is successful we could speed up the process by popping the clean command.
This fix speeds up the test by 5 minutes.