Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: slice loop replace #13962

Merged
merged 1 commit into from
May 28, 2024
Merged

chore: slice loop replace #13962

merged 1 commit into from
May 28, 2024

Conversation

testwill
Copy link
Contributor

Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?

Signed-off-by: guoguangwu <guoguangwug@gmail.com>
Copy link

Hey! testwill has not signed the Canonical CLA which is required to get this contribution merged on this project.

Please head over to https://ubuntu.com/legal/contributors to read more about it.

@bboozzoo bboozzoo requested review from bboozzoo and zyga May 15, 2024 07:17
@bboozzoo bboozzoo added the Simple 😃 A small PR which can be reviewed quickly label May 15, 2024
Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (ab996a0) to head (8aad932).
Report is 225 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13962      +/-   ##
==========================================
- Coverage   78.86%   78.79%   -0.07%     
==========================================
  Files        1043     1046       +3     
  Lines      134595   136218    +1623     
==========================================
+ Hits       106144   107331    +1187     
- Misses      21837    22170     +333     
- Partials     6614     6717     +103     
Flag Coverage Δ
unittests 78.79% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Meulengracht Meulengracht merged commit 9529b3d into snapcore:master May 28, 2024
43 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
5 participants