Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrappers: only fail when stopping a service if it actually is still running #13956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Meulengracht
Copy link
Member

@Meulengracht Meulengracht commented May 9, 2024

I've seen this atleast once in salesforce tickets, and recently experienced it myself. This effectively blocks removal of some snaps in very specific cases.

For instance take the fwupd snap:

philip@fadekraft-xps:~/Work/snapd/wrappers$ snap remove fwupd
error: cannot perform the following tasks:
- Stop snap "fwupd" services (systemctl command [stop snap.fwupd.fwupd.service] failed with exit status 5: stderr:
Failed to stop snap.fwupd.fwupd.service: Unit snap.fwupd.fwupd.service not loaded.)

I have fwupd installed as both a deb and a snap, and this causes systemctl to always return an issue when manipulating the service units for the snaps, as the deb package one loads first and is actually running. The error that systemctl reports is that two units are conflicting for dbus namespace registration.

@Meulengracht Meulengracht force-pushed the feature/service-stop-robustness branch from 937da89 to 3046bb3 Compare June 7, 2024 11:35
@Meulengracht Meulengracht marked this pull request as ready for review June 7, 2024 11:36
Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants