o/snapstate: in hybrid systems re-refresh before reboot if possible #13955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In hybrid systems where we do refreshes of apps before the reboot and essential snaps after, check if a re-refresh is necessary after the apps are done instead of waiting for all (and therefore a reboot). This is possible because currently essential snaps don't use epochs and don't require re-refreshes. If an app has a dependency that requires a reboot (like the model base), then the check-rerefresh task needs to wait for that refresh to complete. Since, if we're waiting for the reboot, there isn't much to gain in resolving the app's dependencies to only wait for those, the check-rerefresh preserves the old behavior in that case to keep things simple. Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
MiguelPires
changed the title
Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
ernestl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hybrid systems where we do refreshes of apps before the reboot and essential snaps after, check if a re-refresh is necessary after the apps are done instead of waiting for all (and therefore a reboot). This is possible because currently essential snaps don't use epochs and don't require re-refreshes. If an app has a dependency that requires a reboot (like the model base), then the check-rerefresh task needs to wait for that refresh to complete. Since, if we're waiting for the reboot, there isn't much to gain in resolving the app's dependencies to only wait for those, the check-rerefresh preserves the old behavior in that case to keep things simple.