Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise error on empty named param #183

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

mbhall88
Copy link
Member

@mbhall88 mbhall88 commented Mar 8, 2023

Closes #125

@mbhall88 mbhall88 requested a review from bricoletc March 8, 2023 04:29
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #183 (db452a7) into master (fd5680a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          12       12           
  Lines        1012     1014    +2     
  Branches      221      222    +1     
=======================================
+ Hits          993      995    +2     
  Misses         10       10           
  Partials        9        9           
Flag Coverage Δ
unittests 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
snakefmt/parser/syntax.py 98.87% <100.00%> (+<0.01%) ⬆️

Copy link
Collaborator

@bricoletc bricoletc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V. nice!
Thank you for addressing all these issues Michael.

@mbhall88 mbhall88 merged commit b5aa660 into snakemake:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty named entry in parameter list is deleted
2 participants