fix: don't raise NotAnIdentifier function

[mbhall88]

closes #177

[codecov]

Codecov Report

Merging #179 (faaad7d) into master (7b35c16) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          12       12           
  Lines        1012     1012           
  Branches      221      221           
=======================================
  Hits          993      993           
  Misses         10       10           
  Partials        9        9           

Flag	Coverage Δ
unittests	98.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
snakefmt/parser/syntax.py	98.86% <100.00%> (ø)

[chillenzer]

Hi, thanks for putting this together. I didn't explicitly mention this in the issue but this is also true for ColonError, NewlineError, and SyntaxFormError.

[mbhall88]

You made me realise that the issue was just that we were trying to raise a function, rather than just calling it.

[bricoletc]

I agree that simply calling the function, rather than erroneously raising it, is the simplest thing to do. Could you rebase -i this PR and remove the first commit, which is now unnecessary - it's just reverted in the last commit of this PR

I can do it if you want ;)

[mbhall88]

Done Brice. Although I was just going to squash-merge this PR anyways.