Refactor .env file setup #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was erroneously omitted from smrealms#961, and only affected the `smr-dev` service.
Volume-mounting individual files is unreliable due to limitations with the way Docker handles inode changes. If editing a file creates a new inode, then those changes will unexpectedly not be propagated into the container. See moby/moby#15793 (comment). To fix this, we will avoid volume-mounting files. We move the `.env` file to `config/env`, so that we can reuse the `config` directory volume-mount. We also create a symlink to `.env` for the convenience of docker-compose commands (since it reads `.env` by default).
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
========================================
Coverage 2.75% 2.75%
Complexity 4062 4062
========================================
Files 74 74
Lines 11199 11199
========================================
Hits 308 308
Misses 10891 10891
Continue to review full report at Codecov.
|
hemberger
added a commit
to hemberger/dockerize
that referenced
this pull request
Feb 15, 2021
hemberger
added a commit
to hemberger/seed-server
that referenced
this pull request
Feb 15, 2021
hemberger
added a commit
to smrealms/seed-server
that referenced
this pull request
Feb 21, 2021
hemberger
added a commit
to hemberger/seed-server
that referenced
this pull request
Feb 21, 2021
hemberger
added a commit
to hemberger/seed-server
that referenced
this pull request
Jul 21, 2021
hemberger
added a commit
to smrealms/seed-server
that referenced
this pull request
Aug 15, 2021
hemberger
added a commit
to smrealms/dockerize
that referenced
this pull request
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volume-mounting individual files is unreliable due to limitations
with the way Docker handles inode changes. If editing a file creates
a new inode, then those changes will unexpectedly not be propagated
into the container.
See moby/moby#15793 (comment).
To fix this, we will avoid volume-mounting files. We move the
.envfile to
config/env, so that we can reuse theconfigdirectoryvolume-mount. We also create a symlink to
.envfor the convenienceof docker-compose commands (since it reads
.envby default).Also, fix upload volume-mount path for the
smr-devservice.