Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Discord.js v13 #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade to Discord.js v13 #35

wants to merge 3 commits into from

Conversation

HoeenCoder
Copy link
Member

Upgrades Discord.js to v13, which enables new features and gets us on the latest API version (which also fixes at least 1 bug).

  • Unit tests need to be fixed/redesigned.

Copy link
Contributor

@AnnikaCodes AnnikaCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I have some time I'll look into fixing unit tests.

src/client.ts Outdated Show resolved Hide resolved
src/command_base.ts Show resolved Hide resolved
src/events.ts Show resolved Hide resolved
src/monitors/rmt.ts Show resolved Hide resolved
src/monitors/rmt.ts Show resolved Hide resolved
@HoeenCoder HoeenCoder marked this pull request as ready for review October 20, 2021 01:17
@AnnikaCodes
Copy link
Contributor

So apparently the issues with unit tests are caused by us extending Discord.js classes with Structures... I'm not sure how this works but I'll try to get to fixing it sometime soon.

The test suite was broken by the v13 update, and considering v13 is
going to involved a large number of changes to the bot,
its best to just wait to fix unit tests until later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants