Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .Appended id subparts to enum additions #2274

Merged
merged 1 commit into from May 13, 2024
Merged

Add .Appended id subparts to enum additions #2274

merged 1 commit into from May 13, 2024

Conversation

rchache
Copy link
Contributor

@rchache rchache commented May 3, 2024

Background

  • Adds a hierarchical subpart of ".Appended.[index]" for enum additions at the end of the list

Testing

unit tests

Links

  • Links to additional context, if necessary
  • Issue #, if applicable (see here for a list of keywords to use for linking issues)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchache rchache requested a review from a team as a code owner May 3, 2024 20:23
@rchache rchache requested a review from hpmellema May 3, 2024 20:23
@mtdowling
Copy link
Member

What’s the use case?

@gosar gosar merged commit f7b5007 into smithy-lang:main May 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosar gosar gosar approved these changes

@hpmellema hpmellema Awaiting requested review from hpmellema hpmellema is a code owner automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rchache @mtdowling @gosar