Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added precursor intensity to PSM, peptide proteoform output file #2365

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

zhuoxinshi
Copy link

No description provided.

@zhuoxinshi zhuoxinshi added Output Enhancement WIP Work in progress, not ready for review labels May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 92.76%. Comparing base (5ee8567) to head (998c1b4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   92.76%   92.76%   -0.01%     
==========================================
  Files         137      137              
  Lines       21166    21179      +13     
  Branches     2924     2930       +6     
==========================================
+ Hits        19635    19646      +11     
- Misses       1049     1050       +1     
- Partials      482      483       +1     
Files Coverage Δ
...etaMorpheus/EngineLayer/Ms2ScanWithSpecificMass.cs 97.11% <100.00%> (+0.14%) ⬆️
MetaMorpheus/EngineLayer/PsmTsv/PsmFromTsv.cs 96.86% <100.00%> (+0.01%) ⬆️
MetaMorpheus/EngineLayer/PsmTsv/PsmTsvReader.cs 89.21% <100.00%> (+0.10%) ⬆️
MetaMorpheus/EngineLayer/PsmTsv/PsmTsvWriter.cs 97.54% <100.00%> (+0.01%) ⬆️
MetaMorpheus/EngineLayer/SpectralMatch.cs 99.44% <75.00%> (-0.28%) ⬇️
MetaMorpheus/TaskLayer/MetaMorpheusTask.cs 88.48% <84.61%> (-0.13%) ⬇️

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@661b1e5). Learn more about missing BASE report.

Current head 5b8a2b4 differs from pull request most recent head abf6ad4

Please upload reports for the commit abf6ad4 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2365   +/-   ##
=========================================
  Coverage          ?   92.79%           
=========================================
  Files             ?      137           
  Lines             ?    21186           
  Branches          ?     2930           
=========================================
  Hits              ?    19660           
  Misses            ?     1045           
  Partials          ?      481           
Files Coverage Δ
MetaMorpheus/EngineLayer/CommonParameters.cs 95.58% <100.00%> (ø)
...etaMorpheus/EngineLayer/Ms2ScanWithSpecificMass.cs 97.11% <100.00%> (ø)
MetaMorpheus/EngineLayer/PsmTsv/PsmFromTsv.cs 96.86% <100.00%> (ø)
MetaMorpheus/EngineLayer/PsmTsv/PsmTsvReader.cs 89.21% <100.00%> (ø)
MetaMorpheus/EngineLayer/PsmTsv/PsmTsvWriter.cs 97.54% <100.00%> (ø)
MetaMorpheus/EngineLayer/SpectralMatch.cs 99.72% <100.00%> (ø)
MetaMorpheus/TaskLayer/MetaMorpheusTask.cs 88.48% <89.47%> (ø)

@zhuoxinshi zhuoxinshi added ready for review and removed WIP Work in progress, not ready for review labels May 27, 2024
Copy link
Contributor

@Alexander-Sol Alexander-Sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add the new useMostAbundantPrecursorIntensity property to the SetAllFileSpecificCommonParams method in MetaMorpheusTask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants