-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetaDraw Fragmentation Reanalysis #2361
base: master
Are you sure you want to change the base?
MetaDraw Fragmentation Reanalysis #2361
Conversation
…nctional code of the new controls finished, just need to integtrate with the existing MetaDraw structure
…to open up the set methods for the fragment ions in each PsmFromTsv
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2361 +/- ##
==========================================
+ Coverage 92.79% 92.81% +0.01%
==========================================
Files 137 139 +2
Lines 21170 21282 +112
Branches 2924 2937 +13
==========================================
+ Hits 19645 19752 +107
- Misses 1045 1048 +3
- Partials 480 482 +2
|
pretty cool. i only ever see yAmmoniaLoss. maybe we need unit tests for each of the ion types? sounds like lots of work...... I wonder if we paste a couple of example spectra into proteinprospector if it sees any other fragments. |
That is a good idea and maybe a good starter project. Our current tests only truly test b, y, and c ions |
Enables the reanalysis of a fragmentation spectrum with additional fragment ion types.
The plotting methods use the MatchedIons of the psm that gets passed in to determine what to plot. To enable this functionality, I had to temporarily replace the fragment ions in the psm with the new matched ions, then put the original ions back in once the plotting has finished.
To use: have your normal MetaDraw Display
Select the additional ions you want to search for
His the search button. The persist check box will enable this research on all new PSMs you plot