added hyperscore calculation to PEP #2360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbollis
reviewed
Apr 17, 2024
| ulong nIonFactorial = GetFactorial((ulong)nIons.Count); | ||
| nIonFactorial = nIonFactorial < 0 ? ulong.MaxValue : nIonFactorial; // this is a hack to prevent overflow | ||
| ulong cIonFactorial = GetFactorial((ulong)cIons.Count); | ||
| cIonFactorial = cIonFactorial < 0 ? ulong.MaxValue : cIonFactorial; // this is a hack to prevent overflow |
There was a problem hiding this comment.
Ulong will overflow after 20 fragment ions. This check will not prevent overflow due to it being unsigned. We should discuss what max value is required. BigInteger does not appear to have a practical limit to its value.
|
I think it goes a bit higher. Nonetheless it is not meant to prevent overflow. When overflow happens a negative number is returned. This check will substitute ulong max for that negative number The answer won't be correct but it will be large. In fact it will be much larger than a decoy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.