-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ignore Coverage] #4 - Digestion params generalization #2341
Open
nbollis
wants to merge
53
commits into
smith-chem-wisc:master
Choose a base branch
from
nbollis:DigestionParamsGeneralization
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Ignore Coverage] #4 - Digestion params generalization #2341
nbollis
wants to merge
53
commits into
smith-chem-wisc:master
from
nbollis:DigestionParamsGeneralization
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into mzlibUpdate
…o new naming convention
…tionParameters. Toml Properties changed to make this work, all tests pass
nbollis
changed the title
#4 - [Waiting on Omics][Waiting on Spectral Match Generalization]Digestion params generalization
#4 - [Waiting on Spectral Match Generalization]Digestion params generalization
Feb 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2341 +/- ##
==========================================
+ Coverage 92.79% 93.00% +0.20%
==========================================
Files 137 137
Lines 21170 21172 +2
Branches 2924 2935 +11
==========================================
+ Hits 19645 19691 +46
+ Misses 1045 998 -47
- Partials 480 483 +3
|
nbollis
changed the title
#4 - [Waiting on Spectral Match Generalization]Digestion params generalization
#4 - Digestion params generalization
Mar 5, 2024
nbollis
changed the title
#4 - Digestion params generalization
#4 - [Waiting on Spectral Match Generalization] Digestion params generalization
Mar 5, 2024
nbollis
changed the title
#4 - [Waiting on Spectral Match Generalization] Digestion params generalization
#4 - Digestion params generalization
Mar 7, 2024
wherein nic embraces the var side |
nbollis
changed the title
#4 - Digestion params generalization
[Ignore Coverage] #4 - Digestion params generalization
Apr 11, 2024
Alexander-Sol
approved these changes
Apr 19, 2024
elaboy
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes digestion parameters in common parameters to enable rna digestion and protein digestion.
In the task windows, I had to move all things dependent upon the digestion agent being a protease into an if clause that casts the IDigestionParams.DigestionAgent into a protease
Needed to improve code coverage so I found a few miscelaneous spots to do so. ModTypeForTreeViewModel and the Glyco Node class