Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enable saving of multiple settings for tasks #2319

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

kscdnw
Copy link

@kscdnw kscdnw commented Nov 28, 2023

On clicking the save button, all task windows would parse the task window to construct the specific MetaMorpheusTask object. This has been broken out into two methods. GetTaskFromGui returns the task, and save task calls GetTaskFromGui. This enables to new task parameter saving architecture to parse the task from the gui without closing the window.

Copy link
Contributor

@nbollis nbollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. One thing to keep in mind is to make sure that the TaskSettingsViewModel initialization is in the same location as where the UpdateFieldsFromTask(TheTask) was previously called.

MetaMorpheus.sln Outdated Show resolved Hide resolved
MetaMorpheus/GUI/MainWindow.xaml Outdated Show resolved Hide resolved
MetaMorpheus/GUI/TaskWindows/CalibrateTaskWindow.xaml.cs Outdated Show resolved Hide resolved
MetaMorpheus/GUI/TaskWindows/GPTMDTaskWindow.xaml.cs Outdated Show resolved Hide resolved
MetaMorpheus/GUI/TaskWindows/GPTMDTaskWindow.xaml.cs Outdated Show resolved Hide resolved
MetaMorpheus/GUI/Views/SaveSettingsControl.xaml.cs Outdated Show resolved Hide resolved
Width="200" VerticalAlignment="Center" HorizontalAlignment="Left"
Click="Save_Click"/>
<!--Command="{Binding SaveSettingsFromWindowCommand}"
CommandParameter="{Binding TypedSettingsName}"-->
Copy link
Contributor

@nbollis nbollis Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Comments

MetaMorpheus/GUI/Views/SaveSettingsWindow.xaml.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@nbollis nbollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much closer. A few minor changes

MetaMorpheus/GUI/TaskWindows/GPTMDTaskWindow.xaml Outdated Show resolved Hide resolved
MetaMorpheus/GUI/TaskWindows/GlycoSearchTaskWindow.xaml Outdated Show resolved Hide resolved
MetaMorpheus/GUI/TaskWindows/XLSearchTaskWindow.xaml Outdated Show resolved Hide resolved
MetaMorpheus/GUI/TaskWindows/XLSearchTaskWindow.xaml.cs Outdated Show resolved Hide resolved
@Alexander-Sol
Copy link
Contributor

This PR is causing appveyor to hang for some reason. It stops in the middle of running the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants