Changed Target Architecture to x64 #2254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2254 +/- ##
==========================================
- Coverage 91.14% 91.05% -0.10%
==========================================
Files 133 133
Lines 20064 20094 +30
Branches 2797 2801 +4
==========================================
+ Hits 18288 18297 +9
- Misses 1280 1298 +18
- Partials 496 499 +3
|
acesnik
requested changes
Mar 9, 2023
| <RemoveFolder Id="MetaMorpheusProgramMenuFolder" On="both" /> | ||
| </Component> | ||
| </Fragment> | ||
| <!--Shorthand way of getting the install directory--> |
There was a problem hiding this comment.
Are these changes intentional?
| @@ -15,12 +15,13 @@ public class MbrAnalysisResults | |||
| public readonly ConcurrentDictionary<ChromatographicPeak, MbrSpectralMatch> BestMbrMatches; | |||
| public readonly FlashLfqResults FlashLfqResults; | |||
| private Dictionary<string, List<string>> PeptideScoreDict; | |||
| public bool MaxQuantAnalysis { get; } | |||
There was a problem hiding this comment.
Are these changes intentional in this file, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mzLib only targets x64 processor architecture. Targeting "Any CPU" introduced warning messages when building.
This PR switches MetaMorpheus to only target x64 architecture. Warnings are no longer generated on build.
This may fix issue #2253, but I wouldn't hold my breath.