Catch exception when file cannot be downloaded #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have several situation when file cannot be downloaded: * youtube: video was removed * youtube: video is private * youtube: confreaks contain wrong embed_code, probably `none` value * vimeo: video doesn't exist * downloaded uncompleted video - we should retry Above conditions should handle live streams too smcabrera#6.
|
@smcabrera do you know some event with live stream video to check this fix ? |
|
I remember there was a livestream at 2015 ruby conf, would it still be on youtube as a livestream now do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several situation when file cannot be downloaded:
nonevalueAbove conditions should handle live streams too #6.