New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply reserved keywords mapping #181
apply reserved keywords mapping #181
Conversation
@mrapitis, @nickschwab please review this PR |
@theresalech Ford has reviewed and approved this PR. |
This is the feedback I have so far for when using the generator. Capitalization overriding rules should only apply to the class names, and not to the enumerated values or to the methods that access them. See the following enums whose getter method names get capitalized: I noticed some inconsistencies in application of the method name changes. Some also have changed the static key values to include PARAM (ex. VehicleDataResult's getResultCodeParam uses KEY_RESULT_CODE_PARAM, but in TouchEvent for getIdParam the key doesn't change. This isn't the only case). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review is finished. See comment from earlier in the conversation. @o-mishch
@crokita In |
Thanks for the clarification. The last part of my post can be ignored, then. |
Tested the changes and things look good. I'm going to change the base to our release branch since we have a release candidate ready for review and revisions. |
Fixes #2
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Verify test app connectivity and that all unit tests pass.
Summary
avoid using keywords when generating RPC definitions.
CLA