New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom video encoder settings and dynamic screen sizes #406
Closed
Closed
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
aac227a
Added support for allowing developers to set custom video encoder set…
asm09fsu abfb28d
Updated SDLStreamingManager's vide encoder to use optimal settings.
asm09fsu 801f54f
Merge remote-tracking branch 'origin/develop' into feature/issue_401_…
asm09fsu f3eb424
Removed surrounding parenthesis on NSNumber-wrapped boolean.
asm09fsu 4694398
Changed videoEncoderSettings to be null_resettable instead of nullabl…
asm09fsu 74ae86f
Added nullable property to streaming media manager for proper cleanup…
asm09fsu 2e929ed
Added support for retrieving screen dimensions from a successful regi…
asm09fsu 1c82de4
Updated SDLStreamingMediaManager's init function to include display c…
asm09fsu 6bb971b
Consolidated inits with a base init that both the deprecated and new …
asm09fsu 1ac0a6b
Removed synthesize of videoEncoderSettings.
asm09fsu 5f7b6c3
Removed external displayCapabilities property.
asm09fsu 0f7226c
Fixed issue relating to error handling of settings up the encoder.
asm09fsu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were correct originally. They're checking that the passed NSError address can be dereferenced, and later retrieved by the developer. See "Generating your own errors" at https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/ErrorHandling/ErrorHandling.html