Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Developer API Enhancements Phase 1 #298

Merged
merged 308 commits into from Aug 8, 2016
Merged

[WIP] Developer API Enhancements Phase 1 #298

merged 308 commits into from Aug 8, 2016
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Oct 7, 2015

  1. In SDLManager store hash and use it when registering if available

    @joeljfischer
    joeljfischer committed Oct 7, 2015
    Copy the full SHA
    4d72520 View commit details
    Browse the repository at this point in the history

  2. Added SDLManager configuration options 

    * Configuration options for lock screen
* Configuration options for TCP debug
* SDLManager implement the lock screen icon callback and store the image
    @joeljfischer
    joeljfischer committed Oct 7, 2015
    Copy the full SHA
    12d7c3e View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2015

  1. Lots of changes for an automatic lock screen through SDLManager 

    * Didn't test lol 👻
    @joeljfischer
    joeljfischer committed Oct 9, 2015
    Copy the full SHA
    cdf7e3b View commit details
    Browse the repository at this point in the history

  2. Update the podspec to build a resource bundle

    @joeljfischer
    joeljfischer committed Oct 9, 2015
    Copy the full SHA
    919ce9e View commit details
    Browse the repository at this point in the history

  3. Fix lock screen trying to display multiple times

    @joeljfischer
    joeljfischer committed Oct 9, 2015
    Copy the full SHA
    3199829 View commit details
    Browse the repository at this point in the history

  4. Hopefully fix lock screen not using proper configuration

    @joeljfischer
    joeljfischer committed Oct 9, 2015
    Copy the full SHA
    ca5b87c View commit details
    Browse the repository at this point in the history

  5. Fix not setting images or background colors to lock screen

    @joeljfischer
    joeljfischer committed Oct 9, 2015
    Copy the full SHA
    86d3de0 View commit details
    Browse the repository at this point in the history

  6. Rename lifecycle config appIcon -> lockScreenAppIcon because it needs… 

    … to be higher res than the appIcon
    @joeljfischer
    joeljfischer committed Oct 9, 2015
    Copy the full SHA
    943a87b View commit details
    Browse the repository at this point in the history

  7. Update sdl_logo vector in sdl assets

    @joeljfischer
    joeljfischer committed Oct 9, 2015
    Copy the full SHA
    36f0efb View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2015

  1. Make a configuration manager to hold different configuration types

    @joeljfischer
    joeljfischer committed Oct 14, 2015
    Copy the full SHA
    868beb8 View commit details
    Browse the repository at this point in the history

  2. Fix having changed methods that should have been added/deprecated

    @joeljfischer
    joeljfischer committed Oct 14, 2015
    Copy the full SHA
    f55f192 View commit details
    Browse the repository at this point in the history

  3. Stub out a few files

    @joeljfischer
    joeljfischer committed Oct 14, 2015
    Copy the full SHA
    488c027 View commit details
    Browse the repository at this point in the history

  4. Add a few properties to SDLFileManager 

    * Import SDLNotificationConstants to SDLManager.h so that when sending RPCs, you get correct Xcode completion
    @joeljfischer
    joeljfischer committed Oct 14, 2015
    Copy the full SHA
    3f3afbc View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2015

  1. Stub out more File Manager enhancements

    @joeljfischer
    joeljfischer committed Oct 15, 2015
    Copy the full SHA
    910192a View commit details
    Browse the repository at this point in the history

  2. Specify nullability for NotificationHandler block and RPCCompletionHa… 

    …ndler block
    @joeljfischer
    joeljfischer committed Oct 15, 2015
    Copy the full SHA
    eab28bd View commit details
    Browse the repository at this point in the history

  3. Stub out SDLArtwork subclass of SDLFile

    @joeljfischer
    joeljfischer committed Oct 15, 2015
    Copy the full SHA
    8830191 View commit details
    Browse the repository at this point in the history

  4. Start implementing SDLPermissionManager

    @joeljfischer
    joeljfischer committed Oct 15, 2015
    Copy the full SHA
    f62f07c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2015

  1. Fix some classes not being public

    @joeljfischer
    joeljfischer committed Oct 16, 2015
    Copy the full SHA
    a95ff39 View commit details
    Browse the repository at this point in the history

  2. Add a currently unused "languagesSupported" to SDLLifecycleConfiguration

    @joeljfischer
    joeljfischer committed Oct 16, 2015
    Copy the full SHA
    f5600f6 View commit details
    Browse the repository at this point in the history

  3. Untested code to call permissions observers when they change

    @joeljfischer
    joeljfischer committed Oct 16, 2015
    Copy the full SHA
    7fd4d12 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2015

  1. SDLFile updates to allow raw data

    @joeljfischer
    joeljfischer committed Oct 19, 2015
    Copy the full SHA
    af1c18a View commit details
    Browse the repository at this point in the history

  2. SDLFileManager delete and upload updates 

    * Added delete and upload methods with completion handlers
* Add a file wrapper "struct" to contain a file and it's completion handler
* Remote files array is now mutable
* Add a currentFileUploadOffset property for large file uploads
* Upload queue now has a constraint
* State is now handled a little differently and affects a few parts
* Fix not doing weak/strongself where necessary
    @joeljfischer
    joeljfischer committed Oct 19, 2015
    Copy the full SHA
    1e30d5c View commit details
    Browse the repository at this point in the history

  3. Fix last build

    @joeljfischer
    joeljfischer committed Oct 19, 2015
    Copy the full SHA
    ab6cf7f View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2015

  1. First attempt at a file manager upload (put file) method. Currently u… 

    …nhappy with it's testability
    @joeljfischer
    joeljfischer committed Oct 20, 2015
    Copy the full SHA
    b6c6287 View commit details
    Browse the repository at this point in the history

  2. Add a comment explaining why i'm unhappy with testability and possibl… 

    …e solutions
    @joeljfischer
    joeljfischer committed Oct 20, 2015
    Copy the full SHA
    78e893d View commit details
    Browse the repository at this point in the history

  3. Fix not resetting file manager state when upload fails or is complete

    @joeljfischer
    joeljfischer committed Oct 20, 2015
    Copy the full SHA
    0b43d1a View commit details
    Browse the repository at this point in the history

  4. Fix "bytesAvailable" not always being accurate after an upload

    @joeljfischer
    joeljfischer committed Oct 20, 2015
    Copy the full SHA
    52ac5ce View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2015

  1. Make the file manager testable by not directly calling SDLManager

    @joeljfischer
    joeljfischer committed Oct 21, 2015
    Copy the full SHA
    cff7311 View commit details
    Browse the repository at this point in the history

  2. Make the connection manager protocol public

    @joeljfischer
    joeljfischer committed Oct 21, 2015
    Copy the full SHA
    359081b View commit details
    Browse the repository at this point in the history

  3. Fix -[SDLFileManager init]

    @joeljfischer
    joeljfischer committed Oct 21, 2015
    Copy the full SHA
    71807a9 View commit details
    Browse the repository at this point in the history

  4. SDLFileManager method completion handlers are nullable

    @joeljfischer
    joeljfischer committed Oct 21, 2015
    Copy the full SHA
    93d41be View commit details
    Browse the repository at this point in the history

  5. SDLEnums are now copyable 

    * Add comments to remaining file manager methods
* Add comments to current permission manager methods
* SDLManager now holds the current HMI level as a public readonly property
* Fix some implicit self capturing
    @joeljfischer
    joeljfischer committed Oct 21, 2015
    Copy the full SHA
    763a46c View commit details
    Browse the repository at this point in the history

  6. Basic implementation of SDLArtwork

    @joeljfischer
    joeljfischer committed Oct 21, 2015
    Copy the full SHA
    c7e308a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2015

  1. Additional methods to remove permissions observers 

    * Additional comments on PermissionManager and FileManager
    @joeljfischer
    joeljfischer committed Oct 26, 2015
    Copy the full SHA
    69cf37f View commit details
    Browse the repository at this point in the history

  2. SDLFIleManager & SDLPermissionManager are accessible through the SDLM… 

    …anager

* SDLFile & SDLArtwork are public
* Error categories are unified in SDLError
* Error constants are now in SDLError
    @joeljfischer
    joeljfischer committed Oct 26, 2015
    Copy the full SHA
    26d9c91 View commit details
    Browse the repository at this point in the history

  3. SDLFileManager has additional details around overwriting files

    @joeljfischer
    joeljfischer committed Oct 26, 2015
    Copy the full SHA
    ceca75b View commit details
    Browse the repository at this point in the history

  4. Updates to lock screen to allow disabling and custom VCs

    @joeljfischer
    joeljfischer committed Oct 26, 2015
    Copy the full SHA
    9be8bdc View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2015

  1. Update unit test frameworks 

    Beginning on unit tests
    @joeljfischer
    joeljfischer committed Oct 28, 2015
    Copy the full SHA
    5849640 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2015

  1. Revamp SDLFile / SDLArtwork to not deal with persistent images 

    * Persistent images will be handled by the pre-start configuration
* Updated SDLFileSpec
* Added test bundle files for testing correct SDLFile behavior
    @joeljfischer
    joeljfischer committed Oct 29, 2015
    Copy the full SHA
    caf1a01 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2015

  1. Bring back persistent SDLFile / SDLArtwork 

    * SDLManager now has a "LifecycleState" enum instead of a "connection" boolean
* SDLManager now won't send requests if connected, but not done with its own setup (e.g. RegisterAppInterface / persistent files). Sending persistant files like that is not yet implemented.
* Started on a state machine class to help with manager states
* SDLError's are now a bit better named
    @joeljfischer
    joeljfischer committed Oct 30, 2015
    Copy the full SHA
    6348920 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2015

  1. Fix state machine errors

    @joeljfischer
    joeljfischer committed Nov 2, 2015
    Copy the full SHA
    0971e70 View commit details
    Browse the repository at this point in the history

  2. Update SDLFileSpec with persistence tests

    @joeljfischer
    joeljfischer committed Nov 2, 2015
    Copy the full SHA
    b5921df View commit details
    Browse the repository at this point in the history

  3. Fix errors with missing test files 

    * Fix SDLFileSpec persistence test looking for wrong file name
    @joeljfischer
    joeljfischer committed Nov 2, 2015
    Copy the full SHA
    aa78a19 View commit details
    Browse the repository at this point in the history

  4. Added an SDLArtworkSpec

    @joeljfischer
    joeljfischer committed Nov 2, 2015
    Copy the full SHA
    e42c8a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2015

  1. Committing SDLPermissionsManagerSpec tests 

    * They currently fail
* SDLPermissionManager private dicationaries are now strong, not copied, since they're private and we're not setting them beyond the initial set
    @joeljfischer
    joeljfischer committed Nov 3, 2015
    Copy the full SHA
    4fa206b View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2015

  1. Initialize SDLPermissionManager private vars 

    * Fixes several tests
    @joeljfischer
    joeljfischer committed Nov 4, 2015
    Copy the full SHA
    705b756 View commit details
    Browse the repository at this point in the history

  2. Fixed adding observers to SDLPermissionManager 

    * Adding an observer previously would not add it since the array holding observers had not been initialized
    @joeljfischer
    joeljfischer committed Nov 4, 2015
    Copy the full SHA
    27cc0c3 View commit details
    Browse the repository at this point in the history

  3. Update commenting in SDLPermissionsManagerSpec 

    * Fix bug causing local vars not to get reset
    @joeljfischer
    joeljfischer committed Nov 4, 2015
    Copy the full SHA
    e34ec9c View commit details
    Browse the repository at this point in the history

  4. Fixed issue in SDLPermissionManager 

    * Fixed an issue in SDLPermissionManager where calling isRPCAllowed:forHMILevel: would always fail
    @joeljfischer
    joeljfischer committed Nov 4, 2015
    Copy the full SHA
    c325c62 View commit details
    Browse the repository at this point in the history

  5. Started on unit tests for SDLFileManager 

    * Fixed a bug causing SDLFileManager remoteFileNames property to always return nil

* SDLFIleManager state is now public

* SDLConnectionManager protocol now specifies that a __kindof SDLRPCRequest may be sent
    @joeljfischer
    joeljfischer committed Nov 4, 2015
    Copy the full SHA
    a068dd5 View commit details
    Browse the repository at this point in the history

  6. Updates to SDLFileManagerSpec 

    * Handle test connectionManager sending back a custom list files
    @joeljfischer
    joeljfischer committed Nov 4, 2015
    Copy the full SHA
    0a47e29 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2015

  1. SDLFileManager now throws an error when trying to delete an unknown file 

    * Some tests around file manager deleting
* Add an error for file manager "no known file with that name" error
    @joeljfischer
    joeljfischer committed Nov 5, 2015
    Copy the full SHA
    cbe091a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2015

  1. SDLFileManagerSpec tests for deleting files

    @joeljfischer
    joeljfischer committed Nov 6, 2015
    Copy the full SHA
    b68182d View commit details
    Browse the repository at this point in the history

  2. FileManager tests around uploading 

    * Separate TestConnectionManager into its own class
* FileManager now sets the bytesAvailable in error states that still have a response
    @joeljfischer
    joeljfischer committed Nov 6, 2015
    Copy the full SHA
    38ee2ea View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2015

  1. SDLFileManager testing around attempted overwriting when it can't ove… 

    …rwrite
    @joeljfischer
    joeljfischer committed Nov 9, 2015
    Copy the full SHA
    f8c710b View commit details
    Browse the repository at this point in the history

  2. Fix test compile errors 

    * Fix not using the correct variable name in file manager tests
    @joeljfischer
    joeljfischer committed Nov 9, 2015
    Copy the full SHA
    7b41edf View commit details
    Browse the repository at this point in the history

  3. Fix a very odd SDLFileManager bug where an mutable set would magicall… 

    …y become immutable

* Change resetting of mutable objects to instead clear or add
* Fix SDLFileManagerSpec delete tests not setting success bool correctly
* Change SDLFileManager remote file names array to a set so they don't add multiple of the same file name
* Fix SDLFileManager bug where self was being captured within a block
    @joeljfischer
    joeljfischer committed Nov 9, 2015
    Copy the full SHA
    482712f View commit details
    Browse the repository at this point in the history

  4. Remove SDLFileManagerSpec test focus 

    * Fix SDLFileManagerSpec "testInitialSpaceAvailable" data not being initialized
    @joeljfischer
    joeljfischer committed Nov 9, 2015
    Copy the full SHA
    7e4ac4c View commit details
    Browse the repository at this point in the history

  5. TestConnectionManager now tracks and sets correlation IDs

    @joeljfischer
    joeljfischer committed Nov 9, 2015
    Copy the full SHA
    35ab7a2 View commit details
    Browse the repository at this point in the history

  6. SDLFileManager fixes 

    * Correctly track upload failures
* Correctly track correlation IDs
* Correctly return from failures

* SDLFileManagerSpec fixes
    @joeljfischer
    joeljfischer committed Nov 9, 2015
    Copy the full SHA
    9bf6be0 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2015

  1. Resolve remaining SDLFileManagerSpec failed tests of tests that exist

    @joeljfischer
    joeljfischer committed Nov 10, 2015
    Copy the full SHA
    abac844 View commit details
    Browse the repository at this point in the history

  2. Add another bracket of SDLFileManagerSpec tests 

    * Adds tests for remote file not already existing
    @joeljfischer
    joeljfischer committed Nov 10, 2015
    Copy the full SHA
    704040d View commit details
    Browse the repository at this point in the history

  3. More file manager tests for force uploading

    @joeljfischer
    joeljfischer committed Nov 10, 2015
    Copy the full SHA
    c2b602c View commit details
    Browse the repository at this point in the history

  4. NSMapTable subscripting tests

    @joeljfischer
    joeljfischer committed Nov 10, 2015
    Copy the full SHA
    5c813f5 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2015

  1. Add appropriate nullability annotations

    @joeljfischer
    joeljfischer committed Nov 13, 2015
    Copy the full SHA
    222c950 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2015

  1. Default file manager overwrite to NO

    @joeljfischer
    joeljfischer committed Nov 17, 2015
    Copy the full SHA
    6775e8f View commit details
    Browse the repository at this point in the history

  2. SDLConfiguration nil reset appType to DEFAULT

    @joeljfischer
    joeljfischer committed Nov 17, 2015
    Copy the full SHA
    ecf676a View commit details
    Browse the repository at this point in the history

  3. Updating PermissionManager to observe HMI level changes

    @joeljfischer
    joeljfischer committed Nov 17, 2015
    Copy the full SHA
    4b16628 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2015

  1. SDLPermissionManager isRPCAllowed now uses current HMI level

    @joeljfischer
    joeljfischer committed Nov 18, 2015
    Copy the full SHA
    cbc5019 View commit details
    Browse the repository at this point in the history

  2. Rewrite PermissionManager: Everything changed 

    * ADDED: New SDLPermissionConstants file to hold constants, enums, typedefs, and block declarations for Permissions
* ADDED: New private SDLPermissionFilter class that encapsulates a set of RPC Names, change type to watch for, observer block to be called, and an identifier
* CHANGED: SDLPermissionManager now uses the typedef SDLPermissionRPCName instead of string everywhere, not just in generics for clarity
* ADDED: SDLPermissionManager permissionStatusForRPCs: public method that takes an array of RPC names and returns if they are all allowed, all disallowed, or mixed.
* ADDED: SDLPermissionManager permissionAllowedDictForRPCs: public method that takes an array of RPC names and returns a dictionary with whether or not those RPCs are currently allowed.
* CHANGE: SDLPermissionManager addObserverForRPC:usingBlock: is now addObserverForRPC:onChange:withBlock:. The new method allows more specificity of when the observer will be called. The observer can now be called only when all of the RPCs passed in become allowed or disallowed. The new method also returns an identifier that can be used to remove the observer.
* SDLPermissionManager addObserverForRPCs:usingBlock: is now addObserverForRPCs:onChange:withBlock:. The new method allows more specificity of when the observer will be called. The observer can now be called only when all of the RPCs passed in become allowed or disallowed. The new method also returns an identifier that can be used to remove the observer.
* SDLPermissionManager removeObserversForRPCs: is now removeObserverForIdentifier: that takes an identifier returned from an add method.
* Totally refactored the internals of the SDLPermissionManager class. Almost nothing works the same way.
* Not unit tested yet
    @joeljfischer
    joeljfischer committed Nov 18, 2015
    Copy the full SHA
    8830ada View commit details
    Browse the repository at this point in the history

  3. Fix build error from a last minute method refactor

    @joeljfischer
    joeljfischer committed Nov 18, 2015
    Copy the full SHA
    e2b1fe8 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2015

  1. Add a protocol showing an NSNumber's contained type 

    * Removed a typedef that was attempting to do the same thing
    @joeljfischer
    joeljfischer committed Nov 19, 2015
    Copy the full SHA
    1388f51 View commit details
    Browse the repository at this point in the history

  2. Fix public files marked as private

    @joeljfischer
    joeljfischer committed Nov 19, 2015
    Copy the full SHA
    d600e0c View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2015

  1. Add nullability to SDLPermissionObserver

    @joeljfischer
    joeljfischer committed Nov 20, 2015
    Copy the full SHA
    86b3dd4 View commit details
    Browse the repository at this point in the history

  2. Partial SDLPermissionFilter unit tests

    @joeljfischer
    joeljfischer committed Nov 20, 2015
    Copy the full SHA
    bb15e8e View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2015

  1. SDLPermissionFilterSpec complete

    @joeljfischer
    joeljfischer committed Nov 23, 2015
    Copy the full SHA
    8b27be4 View commit details
    Browse the repository at this point in the history

  2. Working on rewritten unit tests for SDLPermissionManager 

    * Remove `SDLPermissionManager addObserverForRPC:onChange:withBlock:`. Developers will have to always use `addObserverForRPCs:onChange:withBlock:`.

* Removed tests related to `addObserverForRPC:onChange:withBlock:`

* Removed testing of non-existent `remove` methods
    @joeljfischer
    joeljfischer committed Nov 23, 2015
    Copy the full SHA
    1bd6ba3 View commit details
    Browse the repository at this point in the history

  3. Additional refactoring on SDLPermissionSpec removal tests

    @joeljfischer
    joeljfischer committed Nov 23, 2015
    Copy the full SHA
    aaaca1d View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2015

  1. Rename a few variables in SDLPermissionManager for clarity

    @joeljfischer
    joeljfischer committed Nov 24, 2015
    Copy the full SHA
    88d0c61 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2015

  1. Several more SDLPermissionManager tests around already existing data

    @joeljfischer
    joeljfischer committed Nov 25, 2015
    Copy the full SHA
    e504858 View commit details
    Browse the repository at this point in the history

  2. Break everything by making type modifications to Permissions

    @joeljfischer
    joeljfischer committed Nov 25, 2015
    Copy the full SHA
    6809211 View commit details
    Browse the repository at this point in the history

  3. Couple of SDLPermissionSpec fixes for Permission type changes 

    * Still more left to do
    @joeljfischer
    joeljfischer committed Nov 25, 2015
    Copy the full SHA
    5e702a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2015

  1. Refactor Permission constant name to not conflict 

    * Fix up some tests to use newer methods, further revision is necessary
    @joeljfischer
    joeljfischer committed Nov 30, 2015
    Copy the full SHA
    5f2fd40 View commit details
    Browse the repository at this point in the history

  2. Many additional SDLPermissionManager tests

    @joeljfischer
    joeljfischer committed Nov 30, 2015
    Copy the full SHA
    a9b732d View commit details
    Browse the repository at this point in the history

  3. Fix tests not running 

    * Fix SDLPermissionFilter tests referencing wrong types

* Change a few method names on SDLPermissionManager

* Add more SDLPermissionManager tests
    @joeljfischer
    joeljfischer committed Nov 30, 2015
    Copy the full SHA
    ec1d853 View commit details
    Browse the repository at this point in the history

  4. Fix updated HMI levels not updating the SDLPermissionManager stored h… 

    …mi level
    @joeljfischer
    joeljfischer committed Nov 30, 2015
    Copy the full SHA
    69052b4 View commit details
    Browse the repository at this point in the history

  5. Fix setup for test in SDLPermissionsManagerSpec 

    * Clarify some documentation
    @joeljfischer
    joeljfischer committed Nov 30, 2015
    Copy the full SHA
    2a71ec0 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2015

  1. Fix PermissionManager not returning Mixed group status when there are… 

    … only 2 rpcs in the group

* Updated tests
* Added tests
* Clarify documentation
* Change the name of a parameter variable to be clearer
    @joeljfischer
    joeljfischer committed Dec 1, 2015
    Copy the full SHA
    7c12b05 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2015

  1. Fixed SDLPermissionManager removeObserverForIdentifier: looping throu… 

    …gh observers twice

*Fix several more test cases for SDLPermissionManager
    @joeljfischer
    joeljfischer committed Dec 2, 2015
    Copy the full SHA
    8b4c4c6 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2015

  1. Fix a few more tests

    @joeljfischer
    joeljfischer committed Dec 3, 2015
    Copy the full SHA
    2801617 View commit details
    Browse the repository at this point in the history

  2. Completely change the SDLPermissionManager update diffing algorithm a… 

    …gain. Now take into account the filter group type.
    @joeljfischer
    joeljfischer committed Dec 3, 2015
    Copy the full SHA
    8b57ce2 View commit details
    Browse the repository at this point in the history

  3. Fix having a wrong variable name

    @joeljfischer
    joeljfischer committed Dec 3, 2015
    Copy the full SHA
    146c4a7 View commit details
    Browse the repository at this point in the history

  4. Fix asserts in permission manager notification callbacks

    @joeljfischer
    joeljfischer committed Dec 3, 2015
    Copy the full SHA
    c045324 View commit details
    Browse the repository at this point in the history

  5. Fix a bug in the Permission Manager update algorithm 

    * Fix a Permission Manager issue where equality testing would fail for filters, occassionally causing a dictionary check in the permissions update algorithm to return an incorrect value
* Add description method to permission filter
* Fix permissions update algorithm to call observers on the correct filters
* Fix equality testing for filters
* Add additional tests for Permission Manager
    @joeljfischer
    joeljfischer committed Dec 3, 2015
    Copy the full SHA
    bda90bc View commit details
    Browse the repository at this point in the history

  6. Actually fix the bug in the permission update algorithm 

    * Remove focusing from the PermissionManagerSpec
    @joeljfischer
    joeljfischer committed Dec 3, 2015
    Copy the full SHA
    70120f6 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2016

  1. Rename SDLConnectionManager (protocol) to SDLConnectionManagerType

    @joeljfischer
    joeljfischer committed Jan 26, 2016
    Copy the full SHA
    e50c407 View commit details
    Browse the repository at this point in the history

  2. Remove putFileStream:withRequest: from SDLManager in favor of the F… 

    …ile Manager
    @joeljfischer
    joeljfischer committed Jan 26, 2016
    Copy the full SHA
    ad25e2f View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2016

  1. Merge branch 'develop' into feature/enhanced_framework 

    Conflicts:
	SmartDeviceLink-iOS.podspec
	SmartDeviceLink-iOS/Cartfile.private
	SmartDeviceLink-iOS/Cartfile.resolved
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Headers/DSL.h
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Headers/Nimble-Swift.h
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Headers/Nimble.h
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Info.plist
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Modules/Nimble.swiftmodule/arm.swiftdoc
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Modules/Nimble.swiftmodule/arm.swiftmodule
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Modules/Nimble.swiftmodule/arm64.swiftdoc
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Modules/Nimble.swiftmodule/arm64.swiftmodule
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Modules/Nimble.swiftmodule/i386.swiftdoc
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Modules/Nimble.swiftmodule/i386.swiftmodule
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Modules/Nimble.swiftmodule/x86_64.swiftdoc
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Modules/Nimble.swiftmodule/x86_64.swiftmodule
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/Nimble
	SmartDeviceLink-iOS/Carthage/Build/iOS/Nimble.framework/_CodeSignature/CodeResources
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Headers/Quick-Swift.h
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Headers/Quick.h
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Info.plist
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/arm.swiftdoc
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/arm.swiftmodule
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/arm64.swiftdoc
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/arm64.swiftmodule
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/i386.swiftdoc
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/i386.swiftmodule
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/x86_64.swiftdoc
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/x86_64.swiftmodule
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Quick
	SmartDeviceLink-iOS/SmartDeviceLink-iOS.xcodeproj/project.pbxproj
    @joeljfischer
    joeljfischer committed Feb 24, 2016
    Copy the full SHA
    1b71732 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2016

  1. Merge branch 'develop' into feature/enhanced_framework 

    Conflicts:
	SmartDeviceLink-iOS.podspec
    @joeljfischer
    joeljfischer committed Feb 26, 2016
    Copy the full SHA
    a0b80dd View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2016

  1. Merge branch 'develop' into feature/enhanced_framework 

    Conflicts:
	SmartDeviceLink-iOS.podspec
    @joeljfischer
    joeljfischer committed Mar 4, 2016
    Copy the full SHA
    1404c61 View commit details
    Browse the repository at this point in the history

  2. DeleteCommand and UnsubscribeButton removes appropriate handlers

    @joeljfischer
    joeljfischer committed Mar 4, 2016
    Copy the full SHA
    8cd8b3d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2016

  1. Some comments to SDLManager

    @joeljfischer
    joeljfischer committed Mar 7, 2016
    Copy the full SHA
    ece1857 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2016

  1. Merge branch 'develop' into feature/enhanced_framework

    @joeljfischer
    joeljfischer committed Mar 9, 2016
    Copy the full SHA
    39d1744 View commit details
    Browse the repository at this point in the history

  2. Add ScrollableMessage and Alert handlers to soft button handler maps

    @joeljfischer
    joeljfischer committed Mar 9, 2016
    Copy the full SHA
    b5820e0 View commit details
    Browse the repository at this point in the history

  3. Remove some comments

    @joeljfischer
    joeljfischer committed Mar 9, 2016
    Copy the full SHA
    0d890f1 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2016

  1. Merge branch 'develop' into feature/enhanced_framework 

    Conflicts:
	SmartDeviceLink-iOS/Cartfile.private
	SmartDeviceLink-iOS/Cartfile.resolved
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/arm.swiftdoc
	SmartDeviceLink-iOS/Carthage/Build/iOS/Quick.framework/Modules/Quick.swiftmodule/arm64.swiftdoc
	SmartDeviceLink-iOS/SmartDeviceLink-iOS.xcodeproj/project.pbxproj
    @joeljfischer
    joeljfischer committed Mar 30, 2016
    Copy the full SHA
    4cc1a05 View commit details
    Browse the repository at this point in the history

  2. Slightly better naming

    @joeljfischer
    joeljfischer committed Mar 30, 2016
    Copy the full SHA
    8c29831 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2016

  1. Fix a misplaced brace

    @joeljfischer
    joeljfischer committed Apr 12, 2016
    Copy the full SHA
    c9a8351 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2016

  1. Merge branch 'develop' into feature/enhanced_framework 

    Conflicts:
	SmartDeviceLink-iOS/SmartDeviceLink-iOS.podspec
    @asm09fsu
    asm09fsu committed Apr 25, 2016
    Copy the full SHA
    4e45d9f View commit details
    Browse the repository at this point in the history

  2. Fixed import in TestConnectionManager from SDLConnectionManager to SD… 

    …LConnectionManagerType.
    @asm09fsu
    asm09fsu committed Apr 25, 2016
    Copy the full SHA
    cf2f7ab View commit details
    Browse the repository at this point in the history

  3. Fixed import in TestConnectionManager from SDLConnectionManager to SD… 

    …LConnectionManagerType.
    @asm09fsu
    asm09fsu committed Apr 25, 2016
    Copy the full SHA
    04d73b0 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2016

  1. Merge branch 'develop' into feature/enhanced_framework

    @joeljfischer
    joeljfischer committed May 4, 2016
    Copy the full SHA
    a894ce8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/enhanced_framework

    @joeljfischer
    joeljfischer committed May 4, 2016
    Copy the full SHA
    139b1fc View commit details
    Browse the repository at this point in the history

  3. Fix testing frameworks not copied into test scheme

    @joeljfischer
    joeljfischer committed May 4, 2016
    Copy the full SHA
    0448ef9 View commit details
    Browse the repository at this point in the history

  4. Keep adding nullability markings for the enhanced dev api

    @joeljfischer
    joeljfischer committed May 4, 2016
    Copy the full SHA
    6853938 View commit details
    Browse the repository at this point in the history

  5. Update state machine 

    * State machine state is now a string
* State machine transition failure now returns an error instead of throwing an exception
* SDLFileManager now uses SDLStateMachine for states
    @joeljfischer
    joeljfischer committed May 4, 2016
    Copy the full SHA
    e800ceb View commit details
    Browse the repository at this point in the history

Commits on May 5, 2016

  1. Expose the current state of SDLFileManager

    @joeljfischer
    joeljfischer committed May 5, 2016
    Copy the full SHA
    ee35852 View commit details
    Browse the repository at this point in the history

  2. Update SDLManager with a state machine 

    * Update SDLStateMachine `isState:` to `isCurrentState:`
    @joeljfischer
    joeljfischer committed May 5, 2016
    Copy the full SHA
    d646141 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2016

  1. Change SDLFile's public initialization API

    @joeljfischer
    joeljfischer committed May 6, 2016
    Copy the full SHA
    2233977 View commit details
    Browse the repository at this point in the history

  2. SDLStateManager now throws an exception on transition failure once again 

    * Allow transitions from a state to the same state
    @joeljfischer
    joeljfischer committed May 6, 2016
    Copy the full SHA
    acd6142 View commit details
    Browse the repository at this point in the history

  3. SDLFileManager updates 

    * SDLFileManager initialization now takes a list of initial persistent files
* SDLFileManager updated for the updated state machine
* Alter SDLFileManager states and make some updates to follow those new states
    @joeljfischer
    joeljfischer committed May 6, 2016
    Copy the full SHA
    ba229a9 View commit details
    Browse the repository at this point in the history

  4. SDLLifecycleConfiguration updates 

    * SDLLifecycleConfiguration initialization properly initializes all its properties
* SDLLifecycleConfiguration properly copies all properties
* Rename persistentImages property to persistentFiles and throw an exception if any are set that are not persistent
*
    @joeljfischer
    joeljfischer committed May 6, 2016
    Copy the full SHA
    9c8d126 View commit details
    Browse the repository at this point in the history

  5. Update SDLManager 

    * Alter available states
* Pass initial persistent files to file manager on initialization
    @joeljfischer
    joeljfischer committed May 6, 2016
    Copy the full SHA
    4574186 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2016

  1. SDLStateMachine updates 

    * Transitions now post NSNotifications
* `initWithTarget:states:startState:` -> `initWithTarget:initialState:states:`
    @joeljfischer
    joeljfischer committed May 9, 2016
    Copy the full SHA
    2c416e6 View commit details
    Browse the repository at this point in the history

  2. SDLManager move code to state handlers 

    * Update SDLManager & SDLFileManager to use new state machine initializer
    @joeljfischer
    joeljfischer committed May 9, 2016
    Copy the full SHA
    2b67965 View commit details
    Browse the repository at this point in the history

  3. Run SDLManager notifications on the main thread

    @joeljfischer
    joeljfischer committed May 9, 2016
    Copy the full SHA
    780d74b View commit details
    Browse the repository at this point in the history

  4. Fix SDLFileManager bugs 

    * Fix SDLFileManagerStateIdle allowable states
* Fix splitting files not shifting the offset
* Shift code into state transition handlers where appropriate
    @joeljfischer
    joeljfischer committed May 9, 2016
    Copy the full SHA
    8b4c339 View commit details
    Browse the repository at this point in the history

  5. Tiny SDLFileManager updates

    @joeljfischer
    joeljfischer committed May 9, 2016
    Copy the full SHA
    178288c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into feature/enhanced_framework 

    Conflicts:
	SmartDeviceLink-iOS/SmartDeviceLink-iOS.xcodeproj/project.pbxproj
    @joeljfischer
    joeljfischer committed May 9, 2016
    Copy the full SHA
    9515966 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2016

  1. Work on SDLManager starting other managers 

    * Create a #define for BLOCK_RETURN as a semantic help
*SDLFileManager now has a start method with a completion block
    @joeljfischer
    joeljfischer committed May 10, 2016
    Copy the full SHA
    0843f6a View commit details
    Browse the repository at this point in the history

  2. SDLFileManager shift more code into state transitions

    @joeljfischer
    joeljfischer committed May 10, 2016
    Copy the full SHA
    8205589 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2016

  1. Rename a few states 

    * SDLFileManager no longer observes connect / disconnect notifications
    @joeljfischer
    joeljfischer committed May 11, 2016
    Copy the full SHA
    0a4e34d View commit details
    Browse the repository at this point in the history

  2. Basically rewrite the file manager 

    * File Manager is now NSOperation based. The `uploadQueue` is now an NSOperationQueue called the `transactionQueue` to handle deletes as well
* NSDeleteFileOperation and NSUploadFileOperation are new classes to split appropriate code into separate places
    @joeljfischer
    joeljfischer committed May 11, 2016
    Copy the full SHA
    9dca14a View commit details
    Browse the repository at this point in the history

Commits on May 12, 2016

  1. SDLFileManager remove unnecessary states 

    * Since we no longer manually manage a queue, we don't need the concept of "checking queue", "uploading", or "idle", so change them all to a "ready" state.

* Remove the concept of initial uploads
    @joeljfischer
    joeljfischer committed May 12, 2016
    Copy the full SHA
    f050ea4 View commit details
    Browse the repository at this point in the history

  2. SDLFileManager Expose the number of pending operations

    @joeljfischer
    joeljfischer committed May 12, 2016
    Copy the full SHA
    b22965c View commit details
    Browse the repository at this point in the history

  3. Group up file manager files

    @joeljfischer
    joeljfischer committed May 12, 2016
    Copy the full SHA
    5bccae5 View commit details
    Browse the repository at this point in the history

  4. Add start method to permission manager 

    * FileManager start method no longer passes back bytes available
    @joeljfischer
    joeljfischer committed May 12, 2016
    Copy the full SHA
    48c1a33 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2016

  1. Create a SDLPermissionManager stop method that does nothing 

    * Make certain the upload file operation does not call dispatch_group_notify until all putfiles have been sent.
    @joeljfischer
    joeljfischer committed May 13, 2016
    Copy the full SHA
    09baf5e View commit details
    Browse the repository at this point in the history

  2. SDLFiles created with data now write to a temp file on disk until upload 

    * SDLFileManager manages the deletion of these files
    @joeljfischer
    joeljfischer committed May 13, 2016
    Copy the full SHA
    4a613b6 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2016

  1. Update SDLArtwork with documentation 

    * Update helper initializers to be class methods
    @joeljfischer
    joeljfischer committed May 17, 2016
    Copy the full SHA
    ff90421 View commit details
    Browse the repository at this point in the history

  2. Fix misspelling in file manager

    @joeljfischer
    joeljfischer committed May 17, 2016
    Copy the full SHA
    579e022 View commit details
    Browse the repository at this point in the history

  3. Fix some broken stuff

    @joeljfischer
    joeljfischer committed May 17, 2016
    Copy the full SHA
    07bbace View commit details
    Browse the repository at this point in the history

Commits on May 18, 2016

  1. Post a notification when the SDLManager is ready

    @joeljfischer
    joeljfischer committed May 18, 2016
    Copy the full SHA
    43effca View commit details
    Browse the repository at this point in the history

  2. When SDLManager stop is called, transition to disconnected state 

    * Remove an unused enum
* Document the start method on SDLManager
    @joeljfischer
    joeljfischer committed May 18, 2016
    Copy the full SHA
    7049aaf View commit details
    Browse the repository at this point in the history

Commits on May 19, 2016

  1. Expose StreamingMediaManager on SDLManager

    @joeljfischer
    joeljfischer committed May 19, 2016
    Copy the full SHA
    a8ccbda View commit details
    Browse the repository at this point in the history

  2. Store the register app interface response 

    * Fix Streaming Media Manager forward class in manager header
    @joeljfischer
    joeljfischer committed May 19, 2016
    Copy the full SHA
    ea99e86 View commit details
    Browse the repository at this point in the history

  3. When "stop" is called on SDLManager, it properly unregisters 

    * Rename Lifecycle state disconnected because the transport *could* still be connected, if the app merely unregistered.
    @joeljfischer
    joeljfischer committed May 19, 2016
    Copy the full SHA
    baa1230 View commit details
    Browse the repository at this point in the history

  4. SDLManager is no longer a singleton

    @joeljfischer
    joeljfischer committed May 19, 2016
    Copy the full SHA
    806379a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into feature/enhanced_framework 

    Conflicts:
	SmartDeviceLink-iOS/SmartDeviceLink-iOS.xcodeproj/project.pbxproj
    @joeljfischer
    joeljfischer committed May 19, 2016
    Copy the full SHA
    b186b07 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2016

  1. Allow the SDLFileManager start completion to be nil

    @joeljfischer
    joeljfischer committed May 24, 2016
    Copy the full SHA
    480fdee View commit details
    Browse the repository at this point in the history

  2. Make sure tests compile after changes 

    * Stub out Upload and Delete File operations specs
* Remove some unneeded file specs
* Fix up errors in test app
    @joeljfischer
    joeljfischer committed May 24, 2016
    Copy the full SHA
    904b695 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2016

  1. Fix failing SDLFile and SDLArtwork tests

    @joeljfischer
    joeljfischer committed May 25, 2016
    Copy the full SHA
    d44bce3 View commit details
    Browse the repository at this point in the history

  2. Fix an analyzer warning for a nonnull property being nil

    @joeljfischer
    joeljfischer committed May 25, 2016
    Copy the full SHA
    6914639 View commit details
    Browse the repository at this point in the history

  3. The delete file operation should actually delete the file

    @joeljfischer
    joeljfischer committed May 25, 2016
    Copy the full SHA
    83d3665 View commit details
    Browse the repository at this point in the history

  4. Create a list files operation and move code out of file manager 

    * Stub a list manager operation spec
* Minor changes and removals to File Manager spec
    @joeljfischer
    joeljfischer committed May 25, 2016
    Copy the full SHA
    45a2e06 View commit details
    Browse the repository at this point in the history

  5. Update TestConnectionManager with nullability and reset

    @joeljfischer
    joeljfischer committed May 25, 2016
    Copy the full SHA
    16e6eea View commit details
    Browse the repository at this point in the history

  6. SDLFileManager updates 

    * Add a suspended BOOL property. When YES, the file manager will be suspended and no further transactions will be completed until it is unsuspended

* Add a `pendingTransactions` readonly property to see operations that are in the queue.
    @joeljfischer
    joeljfischer committed May 25, 2016
    Copy the full SHA
    3cb694c View commit details
    Browse the repository at this point in the history

  7. Start stubbing some SDLListFilesOperation tests

    @joeljfischer
    joeljfischer committed May 25, 2016
    Copy the full SHA
    18300ee View commit details
    Browse the repository at this point in the history

Commits on May 26, 2016

  1. SDLListFilesOperation should actually run and finish 

    * SDLUploadFileOperation should finish at the proper time
    @joeljfischer
    joeljfischer committed May 26, 2016
    Copy the full SHA
    c242636 View commit details
    Browse the repository at this point in the history

  2. Add additional ListFilesOperation tests

    @joeljfischer
    joeljfischer committed May 26, 2016
    Copy the full SHA
    969c36a View commit details
    Browse the repository at this point in the history

  3. Fix a bug with operations causing them to not set executing to YES

    @joeljfischer
    joeljfischer committed May 26, 2016
    Copy the full SHA
    34373e1 View commit details
    Browse the repository at this point in the history

  4. Move SDLFileManager list files to a separate method

    @joeljfischer
    joeljfischer committed May 26, 2016
    Copy the full SHA
    da0030d View commit details
    Browse the repository at this point in the history

  5. Fix SDLListFilesOperation not setting completion handler

    @joeljfischer
    joeljfischer committed May 26, 2016
    Copy the full SHA
    d7433d1 View commit details
    Browse the repository at this point in the history

  6. Add DeleteFileOperation tests

    @joeljfischer
    joeljfischer committed May 26, 2016
    Copy the full SHA
    4586879 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2016

  1. Add some class documentation to SDLFileManager

    @joeljfischer
    joeljfischer committed May 27, 2016
    Copy the full SHA
    7855828 View commit details
    Browse the repository at this point in the history

  2. Upload file operation tests

    @joeljfischer
    joeljfischer committed May 27, 2016
    Copy the full SHA
    a1b546b View commit details
    Browse the repository at this point in the history

  3. Some work on file manager tests

    @joeljfischer
    joeljfischer committed May 27, 2016
    Copy the full SHA
    85027d6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feature/enhanced_framework 

    Conflicts:
	README.md
	SmartDeviceLink-iOS.xcodeproj/project.pbxproj
    @joeljfischer
    joeljfischer committed May 27, 2016
    Copy the full SHA
    8cbaaf1 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2016

  1. Merge branch 'develop' into feature/enhanced_framework

    @joeljfischer
    joeljfischer committed Jun 6, 2016
    Copy the full SHA
    a38a239 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2016

  1. Add an SDLManager convenience method sendRequest: that doesn't have… 

    … a completion handler
    @joeljfischer
    joeljfischer committed Jun 7, 2016
    Copy the full SHA
    f0d1046 View commit details
    Browse the repository at this point in the history

  2. Add a manager delegate for clearer readiness notification

    @joeljfischer
    joeljfischer committed Jun 7, 2016
    Copy the full SHA
    3248c4f View commit details
    Browse the repository at this point in the history

  3. Fix SDLManagerDelegate marked as internal

    @joeljfischer
    joeljfischer committed Jun 7, 2016
    Copy the full SHA
    8447538 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feature/enhanced_framework

    @joeljfischer
    joeljfischer committed Jun 7, 2016
    Copy the full SHA
    72fd367 View commit details
    Browse the repository at this point in the history

  5. Working on getting tests to work on Travis

    @joeljfischer
    joeljfischer committed Jun 7, 2016
    Copy the full SHA
    007d527 View commit details
    Browse the repository at this point in the history

  6. Fix pathing on some testing frameworks

    @joeljfischer
    joeljfischer committed Jun 7, 2016
    Copy the full SHA
    e7050cd View commit details
    Browse the repository at this point in the history

  7. Attempt to get the tests to run properly

    @joeljfischer
    joeljfischer committed Jun 7, 2016
    Copy the full SHA
    6243d20 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2016

  1. Fix the state machine not calling "didEnter" transitions

    @joeljfischer
    joeljfischer committed Jun 27, 2016
    Copy the full SHA
    3de595e View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2016

  1. State machines only send out one notification type

    @joeljfischer
    joeljfischer committed Jun 28, 2016
    Copy the full SHA
    081e1d4 View commit details
    Browse the repository at this point in the history

  2. Force SDLLifecycleConfiguration to be created with required input

    @joeljfischer
    joeljfischer committed Jun 28, 2016
    Copy the full SHA
    8406605 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2016

  1. Fix a bunch of test files not being linked to the project 

    * Fix UploadFileOperations not throwing an error when forcibly stopped
* Fix FileManager resetting it's "bytesAvailable" property in improper situations
* Fix FileManager not updating its remote file list when a new file is successfully uploaded
* Fix a ton of FileManager tests
    @joeljfischer
    joeljfischer committed Jun 29, 2016
    Copy the full SHA
    dd752f4 View commit details
    Browse the repository at this point in the history

  2. Add an additional upload file operation test

    @joeljfischer
    joeljfischer committed Jun 29, 2016
    Copy the full SHA
    afd84e3 View commit details
    Browse the repository at this point in the history

  3. Fix UploadFileSpec failing tests

    @joeljfischer
    joeljfischer committed Jun 29, 2016
    Copy the full SHA
    6c66ce2 View commit details
    Browse the repository at this point in the history

  4. Add new specs for classes that need tests

    @joeljfischer
    joeljfischer committed Jun 29, 2016
    Copy the full SHA
    8787908 View commit details
    Browse the repository at this point in the history

  5. PermissionManager now starts with currentHMILevel as nil 

    * PermissionFilterSpec passes tests
* UploadOperationSpec is no longer focused
    @joeljfischer
    joeljfischer committed Jun 29, 2016
    Copy the full SHA
    e62ee3a View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2016

  1. SDLStateMachine updates and tests 

    * [Enh] StateMachine constant strings are now constant strings
* [Fix] StateMachine now sends notifications even if there isn't an associated target method
* [Enh] StateMachine public method added with the notification name, which is also now the same for all transition types and constant for the state machine based on the target class name
* StateMachine now has a bunch of tests
    @joeljfischer
    joeljfischer committed Jun 30, 2016
    Copy the full SHA
    1329c05 View commit details
    Browse the repository at this point in the history

  2. SDLLockScreenConfiguration tests 

    * Fix LockScreenConfiguration private method not being prefixed
    @joeljfischer
    joeljfischer committed Jun 30, 2016
    Copy the full SHA
    7bd9eb2 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2016

  1. SDLLifecycleConfiguration remove unneeded initializer 

    * Add SDLLifecycleConfiguration documentation
* Fix a test being focussed
* Start on SDLLifecycleConfiguration tests
    @joeljfischer
    joeljfischer committed Jul 1, 2016
    Copy the full SHA
    4bb10a9 View commit details
    Browse the repository at this point in the history

  2. Add additional SDLLifecycleConfiguration tests 

    * Creating a debug SDLLifecycleConfiguration should turn on debug mode
    @joeljfischer
    joeljfischer committed Jul 1, 2016
    Copy the full SHA
    58118b1 View commit details
    Browse the repository at this point in the history

  3. Add SDLConfiguration tests 

    * Add SDLConfiguration documentation
    @joeljfischer
    joeljfischer committed Jul 1, 2016
    Copy the full SHA
    f874337 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2016

  1. Merge branch 'develop' into feature/enhanced_framework

    @joeljfischer
    joeljfischer committed Jul 6, 2016
    Copy the full SHA
    c623c8d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/enhanced_framework

    @joeljfischer
    joeljfischer committed Jul 6, 2016
    Copy the full SHA
    2c83444 View commit details
    Browse the repository at this point in the history

  3. Add appIcon and initialDisplayLayout to LifecycleConfiguration 

    * Add a state to SDLManager to do post-manager setup processing such as setting app icon and display layout
    @joeljfischer
    joeljfischer committed Jul 6, 2016
    Copy the full SHA
    aaae6f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2016

  1. SDLFileManager overwrite is now a property on SDLFile object 

    * Removed "allowOverwrite" property on SDLFileManager
* Removed "forceUpload" method on SDLFileManager
    @joeljfischer
    joeljfischer committed Jul 7, 2016
    Copy the full SHA
    26f03a3 View commit details
    Browse the repository at this point in the history

  2. Add a format method to SDLDebugTool

    @joeljfischer
    joeljfischer committed Jul 7, 2016
    Copy the full SHA
    7006c80 View commit details
    Browse the repository at this point in the history

  3. SDLManager will now set the app icon if configured

    @joeljfischer
    joeljfischer committed Jul 7, 2016
    Copy the full SHA
    8da8b8e View commit details
    Browse the repository at this point in the history

  4. Update SDLFileManager method

    @joeljfischer
    joeljfischer committed Jul 7, 2016
    Copy the full SHA
    f1910a0 View commit details
    Browse the repository at this point in the history

  5. Fix warnings regarding designated initializer

    @joeljfischer
    joeljfischer committed Jul 7, 2016
    Copy the full SHA
    9ef26f1 View commit details
    Browse the repository at this point in the history

  6. Fix SDLManager error state not returning

    @joeljfischer
    joeljfischer committed Jul 7, 2016
    Copy the full SHA
    d574473 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2016

  1. Shift responsibilities out of SDLManager 

    * Move exception creation to SDLError class as a new category on NSException
* Add documentation to some SDLManager public methods
* Rewrite SDLNotificationConstants for more consistency
* Add an SDLNotificationDispatcher private class that acts as a proxy listener and dispatches notifications
* Add an SDLResponseDispatcher private class that takes care of storing and calling handlers on requests sent through SDLManager
    @joeljfischer
    joeljfischer committed Jul 8, 2016
    Copy the full SHA
    6f064b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2016

  1. Add a lock screen manager (SDLLockScreenManager) and move related fun… 

    …ctionality from SDLManager there

* Rename the existing SDLLockScreenManager (in SDLProxy) to SDLLockScreenStatusManager (it was not public).
* Add some TODOs
* SDLResponseDispatcher dispatcher dependency can now be nil
* SDLManager now holds the lock screen manager, initializes it, starts it, and stops it
    @joeljfischer
    joeljfischer committed Jul 12, 2016
    Copy the full SHA
    e2459f0 View commit details
    Browse the repository at this point in the history

  2. Fixed a lot of notification handler method names 

    * Shuffled around files in groups
* Added `managerDidDisconnect` delegate method on SDLManagerDelegate
    @joeljfischer
    joeljfischer committed Jul 12, 2016
    Copy the full SHA
    fb91d2b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2016

  1. Add SDLNotificationDispatcherTests

    @joeljfischer
    joeljfischer committed Jul 13, 2016
    Copy the full SHA
    886e4d1 View commit details
    Browse the repository at this point in the history

  2. Update SDLFileSpec to check overwrite property

    @joeljfischer
    joeljfischer committed Jul 13, 2016
    Copy the full SHA
    a2a8801 View commit details
    Browse the repository at this point in the history

  3. Fix broken SDLFileManager tests

    @joeljfischer
    joeljfischer committed Jul 13, 2016
    Copy the full SHA
    b5a99eb View commit details
    Browse the repository at this point in the history

  4. Update the SDLResponseDispatcher init to be more explicit

    @joeljfischer
    joeljfischer committed Jul 13, 2016
    Copy the full SHA
    3c90ca5 View commit details
    Browse the repository at this point in the history

  5. Start on SDLResponseDispatcherSpec tests

    @joeljfischer
    joeljfischer committed Jul 13, 2016
    Copy the full SHA
    a8731e4 View commit details
    Browse the repository at this point in the history

  6. Fix SDLResponseDispatcher not properly deleting commands in certain c… 

    …ases

* Add more SDLResponseDispatcher tests
    @joeljfischer
    joeljfischer committed Jul 13, 2016
    Copy the full SHA
    3234add View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2016

  1. Fix a bug where SDLResponseDispatcher wouldn’t call a button handler 

    * More ResponseDispatcher tests
    @joeljfischer
    joeljfischer committed Jul 14, 2016
    Copy the full SHA
    ac5f6db View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2016

  1. Create a new SDLLockScreenPresenter object for faking 

    * Start on SDLLockScreenManager tests
* Update SDLLockScreenManager to take a presenter dependency so we can fake the presentation during tests
* Create SDLLockScreenUITests for testing the UI of the lock screen.
    @joeljfischer
    joeljfischer committed Jul 15, 2016
    Copy the full SHA
    67d147a View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2016

  1. Update SDLLockScreenManager 

    * Add SDLFakeViewControllerPresenter that helps unit tests
* Update the SDL Logo to be used on the lock screen
* Add additional Lock Screen Manager tests
* Fix a conflict between SDLLockScreenManagerSpec and the old spec of the same name that was testing the lock screen status manager spec
* SDLLockScreenPresenter protocol now has a dismiss method that’s now implemented in real and fake classes for testing
    @joeljfischer
    joeljfischer committed Jul 18, 2016
    Copy the full SHA
    7f99c44 View commit details
    Browse the repository at this point in the history

  2. Fix a few bugs 

    * Fix RegisterAppInterface failing if VRSynonyms wasn’t set
* Fix PermissionManager failing on an hmi status update
    @joeljfischer
    joeljfischer committed Jul 18, 2016
    Copy the full SHA
    fa76e8a View commit details
    Browse the repository at this point in the history

  3. Add additional SDLLockScreenManagerSpec tests 

    * SDLLockScreenManager dismisses via presenter
    @joeljfischer
    joeljfischer committed Jul 18, 2016
    Copy the full SHA
    17f7a94 View commit details
    Browse the repository at this point in the history

  4. Fix a bug preventing SDLLockScreenManager from presenting the lock sc… 

    …reen
    @joeljfischer
    joeljfischer committed Jul 18, 2016
    Copy the full SHA
    bf59ce5 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2016

  1. Fix SDLLockScreenManager bugs 

    * Fix SDLLockScreenManager not properly receiving vehicle icon
* Rearrange some SDLViewControllerPresentable protocol (and concrete instances) responsibilities for testability purposes
    @joeljfischer
    joeljfischer committed Jul 19, 2016
    Copy the full SHA
    54a1da0 View commit details
    Browse the repository at this point in the history

  2. SDLConfiguration now must take an explicit lock screen configuration

    @joeljfischer
    joeljfischer committed Jul 19, 2016
    Copy the full SHA
    75dbe01 View commit details
    Browse the repository at this point in the history

  3. Update the ProxyManager example to send some initial data

    @joeljfischer
    joeljfischer committed Jul 19, 2016
    Copy the full SHA
    9b3b203 View commit details
    Browse the repository at this point in the history

  4. Shift most SDLManager code into private SDLLifecycleManager for testi… 

    …ng purposes

* Change the name of SDLManagerSpec to SDLLifecycleManager spec and start on a few tests
* Change a bunch of string constants to have more descriptive typedef’d types
* SDLConnectionManagerType protocol now only has one method, a specific one for managers to bypass the `ready` restriction on the public methods
    @joeljfischer
    joeljfischer committed Jul 19, 2016
    Copy the full SHA
    c469e56 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2016

  1. Fix SDLLifecycleManager never reaching the “connected” state 

    * Add notification observers for transport connect, disconnect, and unregister response
    @joeljfischer
    joeljfischer committed Jul 20, 2016
    Copy the full SHA
    80d1724 View commit details
    Browse the repository at this point in the history

  2. Fix a few warnings related to passing null to nonnull parameters 

    * Add additional tests
    @joeljfischer
    joeljfischer committed Jul 20, 2016
    Copy the full SHA
    662a78e View commit details
    Browse the repository at this point in the history

  3. Fix SDLLifecycleManager entering an infinite loop

    @joeljfischer
    joeljfischer committed Jul 20, 2016
    Copy the full SHA
    b187326 View commit details
    Browse the repository at this point in the history

  4. Fix TestConnectionManager

    @joeljfischer
    joeljfischer committed Jul 20, 2016
    Copy the full SHA
    59263d1 View commit details
    Browse the repository at this point in the history

  5. Rename SDLNotificationDispatcher postNotification:info method 

    * Fix SDLLifecycleManager hmi status update infinite loop
* Additional SDLLifecycleManager tests
    @joeljfischer
    joeljfischer committed Jul 20, 2016
    Copy the full SHA
    7e6319e View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2016

  1. Safety and bug fixes 

    * Expose the lifecycle manager’s managers so they can be mocked.
* Modify a bit of code for clarity.
* Clear the response dispatcher when the transport is disconnected.
* State machine will only send one notification per transition.
    @joeljfischer
    joeljfischer committed Jul 21, 2016
    Copy the full SHA
    1b40cbe View commit details
    Browse the repository at this point in the history

  2. Fix unregister causing double disconnect transition

    @joeljfischer
    joeljfischer committed Jul 21, 2016
    Copy the full SHA
    39b5ee4 View commit details
    Browse the repository at this point in the history

  3. Fix typo in a test

    @joeljfischer
    joeljfischer committed Jul 21, 2016
    Copy the full SHA
    aa1d969 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2016

  1. SDLLifecycleManager fixes 

    * Fix attempting to unregister failing
* SDLStateMachine can now directly go to a new state, this is mainly for testing
* A bunch of additional SDLLifecycleManager tests
    @joeljfischer
    joeljfischer committed Jul 22, 2016
    Copy the full SHA
    f3a52f0 View commit details
    Browse the repository at this point in the history

  2. SDLLifecycleManager fixes 

    * SDLLifecycleManager fixed “lastCorrelationId” actually giving the next correlation id
* SDLLifecycleManager fixed sometimes dispatching delegates on main queue, sometimes not. Now where the delegate is called is arbitrary
* Another batch of SDLLifecycleManagerSpec tests
    @joeljfischer
    joeljfischer committed Jul 22, 2016
    Copy the full SHA
    aeacae0 View commit details
    Browse the repository at this point in the history

  3. Fix some broken tests

    @joeljfischer
    joeljfischer committed Jul 22, 2016
    Copy the full SHA
    6f1d8f7 View commit details
    Browse the repository at this point in the history

  4. Fix a few more failing tests

    @joeljfischer
    joeljfischer committed Jul 22, 2016
    Copy the full SHA
    384289a View commit details
    Browse the repository at this point in the history

  5. Minor example app updates

    @joeljfischer
    joeljfischer committed Jul 22, 2016
    Copy the full SHA
    17d31c9 View commit details
    Browse the repository at this point in the history

  6. Minor fixes and additional typechecking 

    * Add asserts in notification handlers if the object isn’t what we expect, just return out in production
    @joeljfischer
    joeljfischer committed Jul 22, 2016
    Copy the full SHA
    6bb1fb4 View commit details
    Browse the repository at this point in the history

  7. Improve the default lock screen 

    * Add white and black sdl logos
* Add code to use the correct white / black logo on the right background color
    @joeljfischer
    joeljfischer committed Jul 22, 2016
    Copy the full SHA
    1bf56b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2016

  1. Add an app icon to the example app 

    * Alter the default lock screen background color to SDL Dark Grey.
* Add documentation around the lock screen configuration
    @joeljfischer
    joeljfischer committed Jul 25, 2016
    Copy the full SHA
    8988032 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2016

  1. Updates and documentation to SDLLifecycleConfiguration 

    * “voiceRecognitionSynonyms” -> “voiceRecognitionCommandNames”
* Some properties are now readonly
* Remove initial display layout since that will be the domain of a different set of code eventually
    @joeljfischer
    joeljfischer committed Jul 26, 2016
    Copy the full SHA
    9e0b05f View commit details
    Browse the repository at this point in the history

  2. Fix method definition error in SDLLockScreenConfiguration

    @joeljfischer
    joeljfischer committed Jul 26, 2016
    Copy the full SHA
    6283438 View commit details
    Browse the repository at this point in the history

  3. Major update of lock screen design and bugfixes 

    * Fix not connecting again because of VR synonyms being sent empty
* Fix default background color not being used because Obj-C
* SDLLifecycleConfiguration’s voiceRecognitionCommandNames can now be sent empty, and will be sent empty by default
* Changed the name of the SDL Example app so that it won’t be truncated
* Removed an unused property from the example app’s ProxyManager class
    @joeljfischer
    joeljfischer committed Jul 26, 2016
    Copy the full SHA
    2498211 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2016

  1. Fix some broken tests caused by changed parameter names

    @joeljfischer
    joeljfischer committed Jul 27, 2016
    Copy the full SHA
    df871a4 View commit details
    Browse the repository at this point in the history

  2. Add FBSnapshotTests cases for SDLLockScreenViewController 

    * Add FBSnapshotTests via Carthage, add license to DEPENDENCIES.md
    @joeljfischer
    joeljfischer committed Jul 27, 2016
    Copy the full SHA
    f48f8c6 View commit details
    Browse the repository at this point in the history

  3. Fix not auto-sending SetAppIcon when it should be 

    * Example app now sets its app icon
* SiphonServer analysis failures commented out
    @joeljfischer
    joeljfischer committed Jul 27, 2016
    Copy the full SHA
    e65ab99 View commit details
    Browse the repository at this point in the history

  4. Add a nicer looking launch screen for the example app

    @joeljfischer
    joeljfischer committed Jul 27, 2016
    Copy the full SHA
    d5e7c9b View commit details
    Browse the repository at this point in the history

  5. Remove an unneeded TODO

    @joeljfischer
    joeljfischer committed Jul 27, 2016
    Copy the full SHA
    9d28d84 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2016

  1. Some general cleanup

    @joeljfischer
    joeljfischer committed Jul 28, 2016
    Copy the full SHA
    416de1c View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2016

  1. The SDLManager delegate can now be set independently

    @joeljfischer
    joeljfischer committed Aug 1, 2016
    Copy the full SHA
    6db3031 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2016

  1. Add lock screen resources to the podspec

    @joeljfischer
    joeljfischer committed Aug 4, 2016
    Copy the full SHA
    026b307 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2016

  1. Add an hmiLevel change delegate callback to SDLManagerDelegate 

    * Add a registerAppInterface property on SDLManager for now I guess ugh
    @joeljfischer
    joeljfischer committed Aug 5, 2016
    Copy the full SHA
    51d5265 View commit details
    Browse the repository at this point in the history

  2. Move storyboard to account for localizations

    @joeljfischer
    joeljfischer committed Aug 5, 2016
    Copy the full SHA
    7d6cd90 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2016

  1. Add a bunch of changelog entries

    @joeljfischer
    joeljfischer committed Aug 8, 2016
    Copy the full SHA
    ef5e8d8 View commit details
    Browse the repository at this point in the history

  2. Add a ton of documentation

    @joeljfischer
    joeljfischer committed Aug 8, 2016
    Copy the full SHA
    6073d1a View commit details
    Browse the repository at this point in the history

  3. Fix library not building and tests erroring… 🙃 

    * Fix SDLRPCRequestFactory tests throwing warnings because they’re testing deprecated methods.
* Fix SDLLifecycleManager tests erroring on no longer extant properties.
* Work around SDLLifecycleManager tests erroring because the RAI response comes inline instead of on a method callback.
* Fix SmartDeviceLink.h erroring because some files don’t exist publicly and some do that did and did not before, respectively.
* SDLLifecycleManager now manually imports each class it uses instead of all classes.
* Removed old properties on SDLLifecycleManager and fix a public / private mismatch on hmiLevel probably causing them not to fire delegate callbacks.
* Stub the hmiLevel delegate callback on the example project.
* Add new tests for calling the hmiLevel SDLManagerDelegate callback
    @joeljfischer
    joeljfischer committed Aug 8, 2016
    Copy the full SHA
    c861e29 View commit details
    Browse the repository at this point in the history

  4. Update version for 4.3.0 alpha 1

    @joeljfischer
    joeljfischer committed Aug 8, 2016
    Copy the full SHA
    075000b View commit details
    Browse the repository at this point in the history