Prevent incorrect background processing

[kmicha19-ford]

Fixes #1799 (when used in conjunction with EASession left open PR #kmicha19-ford#1)

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

• I have verified that I have not introduced new warnings in this PR (or explain why below)
• I have tested this PR against Core and verified behavior.

Unit Tests

• Does not affect any unit tests.

Core Tests

• Built the Obj-C example app and verified that all interactions work
  • iAP disconnect / reconnect
  • LockScreen on/off rapidly
• Built the Swift example app and verified that all interactions work
  • iAP disconnect / reconnect
  • LockScreen on/off rapidly

Summary

This fixes the bug where an app could run on and on unnecessarily even when backgrounded and disconnected.

Changelog

Breaking Changes

• None

Enhancements

• SDLifeCycleManager no longer uses the SDLBackgroundTaskManager.
• SDLBackgroundTaskManager uses the iOS instance method beginBackgroundTask(withName taskName: String?,
  expirationHandler handler: (() -> Void)? = nil) -> UIBackgroundTaskIdentifier
• beginBackgroundTask is for requesting additional processing time when an app is backgrounded and before being suspended so an app can finish tasks, such as saving data, before being suspended. This method is not meant to keep an app running in the background. After 30 seconds iOS may or may not terminate the app
• Using beginBackgroundTask in this manner may conflict with EAAccessory Connect / Disconnect app management and keep the app running in the background when it should be suspended. This may cause undo battery drain.
• It should be noted that SDLSecondaryTransportManager correctly uses SDLBackgroundTaskManager.

Tasks Remaining:

• None

CLA

• I have signed the CLA

[joeljfischer]

@kmicha19-ford Is this a duplicate of #1906?

[kmicha19-ford]

I just Slacked you.

…

________________________________ From: Joel Fischer <notifications@github.com> Sent: Thursday, February 4, 2021 11:19 AM To: smartdevicelink/sdl_ios <sdl_ios@noreply.github.com> Cc: Kinney, Michael (K.A.) <kmicha19@ford.com>; Mention <mention@noreply.github.com> Subject: Re: [smartdevicelink/sdl_ios] Issue 799 prevent incorrect background processing (#1911) @kmicha19-ford<https://clicktime.symantec.com/3HmHZogLckakXDmUh9cvWs57Vc?u=https%3A%2F%2Fgithub.com%2Fkmicha19-ford> Is this a duplicate of #1906<https://clicktime.symantec.com/3BQ7NyTjq2mtbmVUuraLmTx7Vc?u=https%3A%2F%2Fgithub.com%2Fsmartdevicelink%2Fsdl_ios%2Fpull%2F1906>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://clicktime.symantec.com/3GdcbjLt7di68W1gXLkwu5i7Vc?u=https%3A%2F%2Fgithub.com%2Fsmartdevicelink%2Fsdl_ios%2Fpull%2F1911%23issuecomment-773429297>, or unsubscribe<https://clicktime.symantec.com/3Pzm9gBpuGqtCRkvhD1HxPP7Vc?u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIF2K37N27SRLQNMDOONGQTS5LCH3ANCNFSM4XDDGZMA>.

[NicoleYarroch]

@kmicha19-ford I have reviewed this PR and I have not found any issues. I just wanted to hold off on making a review until I got a chance to test with the approved PR #1910 since you mentioned in the PR description that this PR is to be used in conjunction with PR #1910.

[kmicha19-ford]

Great. Let me know how I can help. This is my highest priority now, now that my iMac is back up and running. Yes!