SDL 0296 - Possibility to update video streaming capabilities during ignition cycle #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es update notification (works well)
…ick count on the buttons
… disconnects transport and then establishes and renegotiates new service connection
…video_stream_cap_ POC: SDL 0296 - Possibility to update video streaming capabilities during ignition cycle [issue smartdevicelink#983]
yoooriii
changed the title
|
not ready, let us agree on the poc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983
This PR is ready for review.
Risk
This PR makes no API changes on iOS side.
Testing Plan
Unit Tests
[Describe the unit tests and behaviors added in this PR]
Core Tests
[List of tests performed against Core and behaviors verified]
Core version 6.1.0
HMI name / version / branch / commit hash / module tested against: [INSERT]
Summary
The main purpose of this proposal is to make it possible to update video streaming capabilities during the ignition cycle.
Within the implementation of the Pixel density and Scale proposal, new video streaming capabilities parameters diagonalScreenSize, pixelPerInch and scale were introduced.
Usually, these parameters are passed to SDL Core by the HMI in UI.GetCapabilities response during HMI initialization process. That means if parameters are defined in a current ignition cycle they cannot be updated until the next cycle. However, the HMI is able to change the values of these parameters dynamically, and currently, there is no way to notify SDL Core and Mobile application about the new values.
Changelog
Breaking Changes
Enhancements
Bug Fixes
Tasks Remaining:
CLA