Fix SDLImageField nullability of initializer parameter #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoleYarroch
approved these changes
Apr 17, 2020
joeljfischer
deleted the
bugfix/issue-1625-sdlimagefield-imageresolution-init-nullable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1625
This PR is ready for review.
Risk
This PR makes major API changes. These changes are internal to the next release
Testing Plan
Unit Tests
N/A
Core Tests
This only changed nullability of a parameter, so tests were not performed.
Core version / branch / commit hash / module tested against: n/a
HMI name / version / branch / commit hash / module tested against: n/a
Summary
Update
SDLImageField initWithName:imageTypeSupported:imageResolution:to make theimageResolutionparameternullablelike the property itself.CLA