Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced SDLServiceTypeRPC with service parameter #1610

Merged
merged 1 commit into from Apr 1, 2020

Conversation

lapinskijw
Copy link
Contributor

Fixes #1577

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Ran tests without failure. No unit tests were added or changed.

Core Tests

Core version / branch / commit hash / module tested against: SYNC 3.0 (Build 17276_DEVTEST)
HMI name / version / branch / commit hash / module tested against: sdl_core 6.0.1 (Generic HMI 0.7.2)

Used Trippy app to connect to Core and verified that the correct mtu size was being used.
SYNC 3.0 (Build 17276_DEVTEST):

  • mtu size: 131024

sdl_core 6.0.1 (Generic HMI 0.7.2)

  • mtu size: 131072

Summary

Fixed an issue where we were getting the mtu size from SDLServiceTypeRPC for RPC, video, and audio services. Instead, we are now using the passed in service parameter to get the mtu size.

Changelog

Bug Fixes
  • sdl_sendRawData:onService:encryption: no longer uses SDLServiceTypeRPC to set the mtu size and will now use the mtu size from the service passed in.

CLA

@lapinskijw lapinskijw added bug A defect in the library protocol Relating to the protocol layer labels Mar 31, 2020
@lapinskijw lapinskijw self-assigned this Mar 31, 2020
@NicoleYarroch NicoleYarroch added this to In progress in v6.6.0 via automation Mar 31, 2020
v6.6.0 automation moved this from In progress to Reviewer approved Apr 1, 2020
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with video streaming app on SYNC 4.0 and SYNC 3.0 and with a template app on Manticore (SDL Core v6.0.1 and Generic HMI v0.7.2)

@joeljfischer joeljfischer merged commit 5c0818a into develop Apr 1, 2020
v6.6.0 automation moved this from Reviewer approved to Done Apr 1, 2020
@joeljfischer joeljfischer deleted the bugfix/issue-1577-raw-data-mtu-size branch April 1, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library protocol Relating to the protocol layer
Projects
No open projects
v6.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants