replaced SDLServiceTypeRPC with service parameter #1610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1577
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Ran tests without failure. No unit tests were added or changed.
Core Tests
Core version / branch / commit hash / module tested against: SYNC 3.0 (Build 17276_DEVTEST)
HMI name / version / branch / commit hash / module tested against: sdl_core 6.0.1 (Generic HMI 0.7.2)
Used Trippy app to connect to Core and verified that the correct mtu size was being used.
SYNC 3.0 (Build 17276_DEVTEST):
sdl_core 6.0.1 (Generic HMI 0.7.2)
Summary
Fixed an issue where we were getting the mtu size from
SDLServiceTypeRPC
for RPC, video, and audio services. Instead, we are now using the passed inservice
parameter to get the mtu size.Changelog
Bug Fixes
sdl_sendRawData:onService:encryption:
no longer usesSDLServiceTypeRPC
to set the mtu size and will now use the mtu size from theservice
passed in.CLA