Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated deprecation in Swift example app #1609

Merged
merged 1 commit into from Apr 2, 2020
Merged

Updated deprecation in Swift example app #1609

merged 1 commit into from Apr 2, 2020

Conversation

NicoleYarroch
Copy link
Contributor

Fixes #1607

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

  • N/A as only the example apps were changed.

Core Tests

  • Connected the Swift and Obj-C example apps to Manticore and performed basic smoke tests.

Core version / branch / commit hash / module tested against: Manticore (SDL Core v6.0.1)
HMI name / version / branch / commit hash / module tested against: Manticore (Generic HMI v0.7.2)

Summary

Fixed use of a deprecated init in the Swift example app and updated the corresponding init in the Obj-C app to match.

Changelog

Bug Fixes
  • Fixed use of a deprecated init in the Swift example app.

CLA

@NicoleYarroch
Updated Swift example to use non-deprecated init
bf0f9e4 
Updated Obj-c example match Swift example app
@NicoleYarroch NicoleYarroch added best practice Not a defect but something that should be improved anyway example app Relating to the built-in example apps labels Mar 31, 2020
@NicoleYarroch NicoleYarroch self-assigned this Mar 31, 2020
@NicoleYarroch NicoleYarroch added this to In progress in v6.6.0 via automation Mar 31, 2020
v6.6.0 automation moved this from In progress to Reviewer approved Apr 2, 2020
@joeljfischer joeljfischer merged commit 1f77cfd into develop Apr 2, 2020
v6.6.0 automation moved this from Reviewer approved to Done Apr 2, 2020
@joeljfischer joeljfischer deleted the bugfix/issue_1607_update_deprecations_in__Example_Apps branch April 2, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeljfischer joeljfischer joeljfischer approved these changes

Assignees

@NicoleYarroch NicoleYarroch

Labels
best practice Not a defect but something that should be improved anyway example app Relating to the built-in example apps
Projects
No open projects
v6.6.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NicoleYarroch @joeljfischer