Made the choice set manager thread safe #1603
Conversation
NicoleYarroch
added
bug
Fixed a bug with blocks updating the list of pending and uploaded choices after mgr closed.
NicoleYarroch
changed the title
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
| SDLLogD(@"Finished deleting choices"); | ||
| [weakself.preloadedMutableChoices minusSet:cellsToBeDeleted]; | ||
| // Check if the manager has shutdown because the list of uploaded choices should not be updated | ||
| if ([strongSelf.currentState isEqualToString:SDLChoiceManagerStateShutdown]) { |
There was a problem hiding this comment.
Instead of checking the state here and in other blocks, we could just "reset" all the properties in the start method.
There was a problem hiding this comment.
I'm not sure what you mean by that. Why would resetting properties in start help? They're already reset in didEnterStateShutdown.
There was a problem hiding this comment.
The problem is that the didEnterStateShutdown is called and all the properties reset before the completion block is called for the choice set upload. Then in the completion block, some of the properties are set.
There was a problem hiding this comment.
Ah I gotcha. I think this is a better way to do it. Better not to set the properties at all than to have to reset them later. If a dev checks them while it's shut down it'll show the wrong data.
joeljfischer
deleted the
bugfix/issue_1584_choice_set_manager_not_thread_safe
branch
Fixes #1584
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Added test cases to the SDLChoiceSetManagerSpec to verify that the list of pending and uploaded choice items is not updated after the choice set manager is shutdown. This can happen if the transport is destroyed while choice items are being preloaded, deleted or presented.
Core Tests
Core version / branch / commit hash / module tested against: SYNC 3.0
HMI name / version / branch / commit hash / module tested against: SYNC 3.0
Summary
Made the choice set manager thread safe.
Changelog
Bug Fixes
NSMutableSets at the same time.choiceIdorcancelId.INVALID_ID. This was due to adding choice set items to the list of pending and presenting choice items after the transport was destroyed. Since the library thought those choice items were on the module, they were not uploaded, thus creating an error when trying to present the choice set items.Tasks Remaining:
CLA