Ensure that text and graphic updates aren't sent before we are ready #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
added
bug
NicoleYarroch
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1595
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
No unit tests added, unit tests were run
Core Tests
Disconnect / reconnect tests were run repeatedly
Core version / branch / commit hash / module tested against: Sync Gen 3.4 (19353 DEVTEST)
HMI name / version / branch / commit hash / module tested against: Sync Gen 3.4 (19353 DEVTEST)
Summary
When a display capability update comes in before the manager is ready, a crash will occur because the text and graphic manager is attempting to send an update.
A change was made to ensure that we are actually ready before sending the update.
Changelog
N/A; intra-release issue
CLA