Fix ScreenManager not sending updates in certain cases that it should #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes screen manager sub-managers checking windowCapability nullability, but it's always non-null. Instead, check the image and text fields for nullability
joeljfischer
added
bug
* Add test for setting media track and title in TextAndGraphicManager
* Fix initializer with incorrect parameter types causing a crash
* If we don't have soft button capabilities, suspend the transaction queue
* ChoiceSetManager now suspends and starts its transaction queue in a consistent manner based on the hmi level, system context, and TextFieldName MenuName (Choice primary text) availability. * Updated ChoiceSetManager tests to account for these updates
* If displayCapabilities is nil, allow the transaction queue to run and attempt to show choice sets
NicoleYarroch
suggested changes
Mar 10, 2020
Co-Authored-By: NicoleYarroch <nicole@livio.io>
… of https://github.com/smartdevicelink/sdl_ios into bugfix/issue-1536-empty-displaycapabilities-workaround # Conflicts: # SmartDeviceLink/SDLSoftButtonManager.m
* Update how the soft button manager updates its capabilities * Only send a replace operation if the capabilities changed * Break from the loop early
* Fix `hasData` not returning true if media text or title were available * Separate methods for checking media text / title text fields available
* Fix the choice set manager starting in HMI NONE
* Add a huge number of logs * Add documentation * Don't suspend transaction queue based on system context
NicoleYarroch
suggested changes
Mar 13, 2020
* Reset the HMILevel when the ChoiceSetManager is reset
NicoleYarroch
approved these changes
Mar 17, 2020
joeljfischer
deleted the
bugfix/issue-1536-empty-displaycapabilities-workaround
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1536
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
displayCapabilitiesisnull.Core Tests
Core version / branch / commit hash / module tested against: Sync 3.0 (17276_DEVTEST)
HMI name / version / branch / commit hash / module tested against: Sync 3.0 (17276_DEVTEST)
Summary
This PR fixes a possible case where the head unit sends back a
nildisplayCapabilitiesordisplayCapabilities.textFields / imageFieldswould cause the screen managers to not send data. Instead, we will now send all possible data and leave it to the head unit to reject or show what it determines is appropriate.Changelog
Enhancements
Bug Fixes
nildisplayCapabilitiesordisplayCapabilities.textFields / imageFieldswould cause the screen managers to not send data. Instead, we will now send all possible data and leave it to the head unit to reject or show what it determines is appropriate.textFieldswithout the primary choice text.CLA