Fixed checking if streaming is supported returning wrong value #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoleYarroch
changed the title
joeljfischer
suggested changes
Feb 27, 2020
…_incorrect_value_for_isStreamingSupported
…_incorrect_value_for_isStreamingSupported
…_incorrect_value_for_isStreamingSupported
…_incorrect_value_for_isStreamingSupported
joeljfischer
suggested changes
Mar 18, 2020
SmartDeviceLinkTests/DevAPISpecs/SDLStreamingAudioLifecycleManagerSpec.m
Outdated
Show resolved
Hide resolved
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
joeljfischer
approved these changes
Mar 19, 2020
joeljfischer
deleted the
bugfix/issue_1569_streaming_media_manager_incorrect_value_for_isStreamingSupported
branch
joeljfischer
restored the
bugfix/issue_1569_streaming_media_manager_incorrect_value_for_isStreamingSupported
branch
joeljfischer
deleted the
bugfix/issue_1569_streaming_media_manager_incorrect_value_for_isStreamingSupported
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1569
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
SDLStreamingAudioLifecycleManagerSpecandSDLStreamingVideoLifecycleManagerSpec.Core Tests
Core version / branch / commit hash / module tested against: SYNC 3.0 and Manticore (SDL Core v6.0.1 and Generic HMI v0.7.2)
HMI name / version / branch / commit hash / module tested against: SYNC 3.0 and Manticore (SDL Core v6.0.1 and Generic HMI v0.7.2)
Summary
Fixed the
SDLStreamingMediaManagerreturningfalseforisStreamingSupportedif video/audio has not yet started streaming.Changelog
Bug Fixes
SDLStreamingMediaManagerreturningfalseforisStreamingSupportedif video/audio has not yet started streaming. SinceisStreamingSupportedis set based on the value returned in theRegisterAppInterfaceresponse there is no need to wait for video or audio to start streaming in order to return an accurate value.SDLStreamingAudioLifecycleManagerpossibly setting the wrong value forisStreamingSupportedon pre-4.5.0 head units.CLA