Fix the APT handler was removed after the response handler was called #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Possible solution to second APT being cleared if it's sent in the PAPT response handler
…andler-called # Conflicts: # SmartDeviceLink/SDLResponseDispatcher.m
joeljfischer
added
bug
joeljfischer
changed the title
joeljfischer
changed the title
NicoleYarroch
suggested changes
Feb 27, 2020
* All getters for the properties now use a dispatch_sync * Now runs on the serial processing queue instead of the concurrent processing queue * Reverted most of the tests to only check the properties serially since they're dispatch_sync'd now
NicoleYarroch
approved these changes
Feb 28, 2020
joeljfischer
deleted the
bugfix/issue-1559-fix-APT-removal-after-handler-called
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1559
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Unit tests were run. New unit tests were investigated and added.
AddCommandhandler is removed by the time the handler is called.Core Tests
Tests were performed against the HU based on the reported bug.
PAPTrun from the handler of thePAPTto ensure that a new audio pass thru modal appears.Core version / branch / commit hash / module tested against: Sync 3.0 (17
HMI name / version / branch / commit hash / module tested against: Sync 3.0
Summary
This PR changes the order of operations in the
SDLResponseDispatcherto remove command / button / audio pass thru handlers before calling the response handler of the delete / unsubscribe.Changelog
Bug Fixes
PAPTresponse handler is called, leading to situations where the APT handler would never be called if a newPAPTwere started from the oldPAPTresponse handler.Tasks Remaining:
CLA