Ensure RPC Request thread safety #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
added
bug
joeljfischer
changed the title
NicoleYarroch
suggested changes
Feb 25, 2020
joeljfischer
changed the title
NicoleYarroch
approved these changes
Feb 26, 2020
joeljfischer
deleted the
bugfix/issue-1564-correlationId-thread-safety
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1564
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Unit tests were run, but no new tests were added to the PR because threading issues like this are very difficult to unit test.
Core Tests
An app was run against Core and various functions were tested to ensure that RPC requests continued to function properly.
Core version / branch / commit hash / module tested against: Manticore v2.4.2 (Core v6.0.1)
HMI name / version / branch / commit hash / module tested against: Manticore v2.4.2 (Generic HMI 0.7.2)
Summary
This PR updates lifecycle manager RPC requests to always run on the lifecycle processing queue. This ensures that all access to protected resources will occur both synchronously and on the same queue.
Changelog
Bug Fixes
CLA