Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slider / scrollable message time out message #1548

Merged

Conversation

joeljfischer
Copy link
Contributor

Fixes #1526

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

All changes are example app only, so no unit tests are needed.

Core Tests

  • Time out scrollable message and slider on both Obj-C and Swift example apps

Core version / branch / commit hash / module tested against: Sync 3.0 19205_DEVTEST
HMI name / version / branch / commit hash / module tested against: Sync 3.0 19205_DEVTEST

Summary

This PR changes the error handling the Obj-C and Swift example app menu options to display a Slider and ScrollableMessage. If they timeout, they now display an appropriate alert instead of a confusing one.

Changelog

Bug Fixes
  • Improved the example apps' slider and scrollable message timeout alerts.

CLA

* The message is now clearer
@joeljfischer joeljfischer added best practice Not a defect but something that should be improved anyway example app Relating to the built-in example apps labels Feb 7, 2020
@joeljfischer joeljfischer self-assigned this Feb 7, 2020
@NicoleYarroch NicoleYarroch self-requested a review February 7, 2020 20:49
@NicoleYarroch NicoleYarroch added this to In progress in v6.6.0 via automation Feb 7, 2020
v6.6.0 automation moved this from In progress to Reviewer approved Feb 10, 2020
@joeljfischer joeljfischer merged commit 9e389ad into develop Feb 10, 2020
v6.6.0 automation moved this from Reviewer approved to Done Feb 10, 2020
@joeljfischer joeljfischer deleted the bugfix/issue-1526-swift-example-app-slider-warning-alert branch February 10, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Not a defect but something that should be improved anyway example app Relating to the built-in example apps
Projects
No open projects
v6.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants